[wrapper] replace custom and outdated regexp library with the standard one from the STL #6478
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
AenBleidd
force-pushed
the
vko_replace_regexp_library_with_stdlib
branch
from
34709c5 to
8eb89d0
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…d one from the STL Signed-off-by: Vitalii Koshura <[email protected]>
AenBleidd
force-pushed
the
vko_replace_regexp_library_with_stdlib
branch
from
8eb89d0 to
9fad631
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR replaces a custom and outdated regular expression library with the C++ standard library's <regex> implementation. The change modernizes the codebase by removing approximately 1,600 lines of custom regex code from 2002 and updating the wrapper application to use std::regex.
- Removes all custom regex implementation files and header dependencies
- Updates wrapper.cpp to use
std::regexinstead of the customregexplibrary - Simplifies build configuration by removing regex object file dependencies
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| win_build/wrapper.vcxproj | Removes custom regex source and header files from Windows build |
| samples/wrapper/wrapper.cpp | Replaces custom regex API with std::regex for pattern compilation and matching |
| samples/wrapper/.c/.h | Deletes all custom regex implementation files |
| samples/wrapper/Makefile* | Removes regex object dependencies from build targets |
| lib/Makefile.mingw | Removes regex object dependencies from MinGW build |
| // Compile pattern using std::regex. Try ECMAScript (default), | ||
| // then extended as fallback. | ||
| try { | ||
| zip_patterns.emplace_back(buf); |
There was a problem hiding this comment.
The error message on line 530 references 'pattern' but should reference 'buf' to be consistent with the actual pattern variable being used.
Copilot uses AI. Check for mistakes.
No description provided.