Open
Conversation
… return correct constancy, and made floats strategies default width (to relieve param list failures)
…into strategies_fix
Author
|
I guess I must've forgotten to re-run the tests before making the Having actually run tests on the new version, it looks like they all pass with the exception of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address #360, changes are:
gatesstrategy filter gates ahead of time rather than relying on hypothesisfrozen_gatesto return only non-constant gates when requested, as well as accounting for Noneconstantinputsfloatscalls to use the defaultwidthargument, which drastically reduces the rejection rate for param lists (this defaults to 64-bit floats, which should produce valid params as far as I can tell)