Open
Conversation
timoransky
approved these changes
Feb 24, 2023
timoransky
left a comment
timoransky
left a comment
There was a problem hiding this comment.
Looks good to me, but @palypster please take a look, because I'm not sure if this was bug or a feature 😅
Contributor
|
@FlikoB thank you for this PR. Can you please provide steps how to reproduce the bug behaviour? Please be more verbose. Thank you. Also adding @stringsam to the discussion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix search by values after rescan translations. Translations (values - text column) were not saved into the database after rescan, so therefore it was not possible to search in them.