Changeover to JSON-based testcases and clean dictionary outputs#1006
Merged
BYVoid merged 4 commits intoBYVoid:masterfrom Jan 13, 2026
Merged
Changeover to JSON-based testcases and clean dictionary outputs#1006BYVoid merged 4 commits intoBYVoid:masterfrom
BYVoid merged 4 commits intoBYVoid:masterfrom
Conversation
frankslin
force-pushed
the
feature/issue-1003
branch
2 times, most recently
from
2e2e77b to
52080f8
Compare
- Switch all tests (C++ CLI, Python, Node) to consume `testcases.json` and drop `.in`/`.ans` dependencies; keep filegroup for the JSON. - Prune TWPhrases sub-dictionary artifacts and align DictionaryTest to current generated dict set. - Add rapidjson dep/path for CLI test, refresh_assets script fixes, and keep Bazel Python toolchain note.
- Rename and guard streams in CommandLineConvertTest; ensure input file opens and normalize CRLF. - Fix node test promise handling to propagate errors correctly. - Mark ConfigDictValidationTest as Bazel-only to skip CMake builds.
frankslin
force-pushed
the
feature/issue-1003
branch
from
52080f8 to
9a6cc8b
Compare
BYVoid
approved these changes
Jan 13, 2026
frankslin
added a commit
to frankslin/OpenCC
that referenced
this pull request
Jan 15, 2026
…id#1006) * feature: add a new ConfigDictValidationTest.cpp to be executed in bazel * Changeover to JSON-based testcases and clean dictionary outputs - Switch all tests (C++ CLI, Python, Node) to consume `testcases.json` and drop `.in`/`.ans` dependencies; keep filegroup for the JSON. - Prune TWPhrases sub-dictionary artifacts and align DictionaryTest to current generated dict set. - Add rapidjson dep/path for CLI test, refresh_assets script fixes, and keep Bazel Python toolchain note. * Normalize CommandLineConvertTest for CRLF comparisons on Windows * Address review feedback for tests and Bazel-only validation - Rename and guard streams in CommandLineConvertTest; ensure input file opens and normalize CRLF. - Fix node test promise handling to propagate errors correctly. - Mark ConfigDictValidationTest as Bazel-only to skip CMake builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1003