Skip to content

cmake: fix build error #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JackLau1222 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cmake: fix build error #210

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
cmake_minimum_required(VERSION 3.5 FATAL_ERROR)
# TODO: update 3rd/json cmake version minimum to remove this workaround
set(CMAKE_POLICY_VERSION_MINIMUM "3.5" CACHE STRING "Force CMake policy version to 3.5" FORCE)
Copy link
Collaborator

@sfeiwong sfeiwong Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

具体问题是什么，必须强制其他三方组件也受这个限制？

Copy link
Collaborator Author

@JackLau1222 JackLau1222 Oct 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bmf项目的cmake_minimum_required(VERSION 3.5 FATAL_ERROR)
但是依赖的三方库json用的是cmake_minimum_required(VERSION 3.1)

bmf要求的cmake最低版本大于依赖项目的最低版本 用一些高版本cmake（比如我电脑上的4.0.3）编译时 会报错

CMake Error at 3rd_party/json/CMakeLists.txt:1 (cmake_minimum_required):
Compatibility with CMake < 3.5 has been removed from CMake.

Update the VERSION argument value. Or, use the ... syntax
to tell CMake that the project requires at least but has been updated
to work with policies introduced by or earlier.

Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.

设置这个CMAKE_POLICY_VERSION_MINIMUM=3.5 就是强制更改依赖的项目最低版本都改成3.5与bmf保持一致

Copy link
Collaborator

@sfeiwong sfeiwong Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这样可能会引起其他兼容、策略问题，各自模块约定各自的最低版本更合理一些。


# Cross Compile
# cmake -DCMAKE_TOOLCHAIN_FILE=cmake/aarch64-toolchain.cmake
Expand Down
Loading