[Inspectorv2] Add metadata properties #16975
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Building or testing the playground has failed. If the tests failed, results can be found here: |
packages/dev/inspector-v2/src/components/properties/metadataProperties.tsx
Outdated
Show resolved
Hide resolved
|
Building or testing the sandbox has failed. If the tests failed, results can be found here: |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16975/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16975/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16975/merge#BCU1XR#0 |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
# Conflicts: # packages/dev/inspector-v2/test/app/index.ts
|
You have made possible changes to the playground. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16975/merge/ The snapshot playground with the CDN snapshot (only when available): Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds metadata properties support to inspector v2, allowing users to view and edit metadata attached to scene objects through the inspector interface.
- Adds a new metadata properties service and component for displaying and editing object metadata
- Implements a comprehensive metadata editor with JSON parsing, validation, and formatting capabilities
- Includes test objects with various metadata types for development and testing
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/dev/sharedUiComponents/src/fluent/primitives/textarea.tsx | Adds minimum and maximum height styles to textarea component |
| packages/dev/inspector-v2/test/app/index.ts | Creates test objects with different metadata types for testing the metadata editor |
| packages/dev/inspector-v2/src/services/panes/properties/metadataPropertiesService.tsx | Registers the metadata properties service with the inspector framework |
| packages/dev/inspector-v2/src/inspector.tsx | Adds the metadata properties service to the inspector's service definitions |
| packages/dev/inspector-v2/src/components/properties/metadataProperties.tsx | Implements the main metadata properties component with editing, validation, and formatting features |
packages/dev/inspector-v2/src/components/properties/metadataProperties.tsx
Show resolved
Hide resolved
packages/dev/inspector-v2/src/components/properties/metadataProperties.tsx
Show resolved
Hide resolved
packages/dev/inspector-v2/src/components/properties/metadataProperties.tsx
Show resolved
Hide resolved
packages/dev/inspector-v2/src/components/properties/metadataProperties.tsx
Show resolved
Hide resolved
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
|
You have changed file(s) that made possible changes to the sandbox. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16975/merge/ |
|
You have changed file(s) that made possible changes to the sandbox. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16975/merge/ |
|
You have made possible changes to the playground. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16975/merge/ The snapshot playground with the CDN snapshot (only when available): Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly. |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
packages/dev/inspector-v2/src/components/properties/metadataProperties.tsx
Show resolved
Hide resolved
docEdub
changed the title
packages/dev/inspector-v2/src/components/properties/metadataProperties.tsx
Outdated
Show resolved
Hide resolved
packages/dev/inspector-v2/src/components/properties/metadataProperties.tsx
Outdated
Show resolved
Hide resolved
|
You have made possible changes to the playground. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16975/merge/ The snapshot playground with the CDN snapshot (only when available): Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly. |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
|
You have changed file(s) that made possible changes to the sandbox. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16975/merge/ |
No description provided.