Skip to content

Conversation

georginahalpern
Copy link
Contributor

Addressing comments from #17012 after it merged

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 12, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 12, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 12, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/17014/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 12, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17014/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17014/merge/?snapshot=refs/pull/17014/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 12, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 12, 2025

@georginahalpern georginahalpern enabled auto-merge (squash) August 12, 2025 20:26
@bjsplat
Copy link
Collaborator

bjsplat commented Aug 12, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17014/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17014/merge/?snapshot=refs/pull/17014/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 12, 2025

Building or testing the sandbox has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/17014/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 12, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 12, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 12, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 12, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 12, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/17014/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 12, 2025

Building or testing the playground has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17014/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 12, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 12, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 13, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/17014/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 13, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17014/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17014/merge/?snapshot=refs/pull/17014/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 13, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 13, 2025

@georginahalpern georginahalpern merged commit 70f0308 into BabylonJS:master Aug 13, 2025
19 of 20 checks passed
@georginahalpern georginahalpern deleted the particleCleanup branch August 13, 2025 00:12
georginahalpern added a commit to georginahalpern/Babylon.js that referenced this pull request Aug 20, 2025
Addressing comments from
BabylonJS#17012 after it merged

---------

Co-authored-by: Georgina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants