-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[InspectorV2] Particle attractor PR comments #17014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[InspectorV2] Particle attractor PR comments #17014
Conversation
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
packages/dev/inspector-v2/src/components/properties/particles/particleSystemProperties.tsx
Outdated
Show resolved
Hide resolved
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17014/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/17014/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/17014/merge#BCU1XR#0 |
You have changed file(s) that made possible changes to the sandbox. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/17014/merge/ |
You have made possible changes to the playground. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17014/merge/ The snapshot playground with the CDN snapshot (only when available): Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly. |
WebGL2 visualization test reporter: |
Visualization tests for WebGPU |
packages/dev/inspector-v2/src/components/properties/particles/attractor.tsx
Outdated
Show resolved
Hide resolved
packages/dev/inspector-v2/src/components/properties/particles/particleSystemProperties.tsx
Outdated
Show resolved
Hide resolved
You have made possible changes to the playground. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17014/merge/ The snapshot playground with the CDN snapshot (only when available): Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly. |
Building or testing the sandbox has failed. If the tests failed, results can be found here: |
packages/dev/inspector-v2/src/components/properties/particles/attractor.tsx
Outdated
Show resolved
Hide resolved
packages/dev/inspector-v2/src/components/properties/particles/attractor.tsx
Outdated
Show resolved
Hide resolved
Visualization tests for WebGPU |
WebGL2 visualization test reporter: |
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17014/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/17014/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/17014/merge#BCU1XR#0 |
You have changed file(s) that made possible changes to the sandbox. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/17014/merge/ |
Building or testing the playground has failed. If the tests failed, results can be found here: |
Visualization tests for WebGPU |
WebGL2 visualization test reporter: |
You have changed file(s) that made possible changes to the sandbox. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/17014/merge/ |
You have made possible changes to the playground. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17014/merge/ The snapshot playground with the CDN snapshot (only when available): Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly. |
WebGL2 visualization test reporter: |
Visualization tests for WebGPU |
Addressing comments from BabylonJS#17012 after it merged --------- Co-authored-by: Georgina <[email protected]>
Addressing comments from #17012 after it merged