Skip to content

Conversation

@ryantrem
Copy link
Member

@ryantrem ryantrem commented Nov 14, 2025

NativeTracing has been partially implemented in Babylon Native for a long time. These changes hook up the Babylon.js perf tracing related APIs in Tools to the Babylon Native tracing APIs. This extra functionality will only execute in the context of Babylon Native, and is resilient to older versions of Babylon Native. For these changes to fully work, they need BabylonJS/BabylonNative#1569.

Couple additional changes related to our native interfaces:

  • I did a little bit of cleanup on the INative interface to make it more type safe
  • I added a declation for the _native global in INativeInterfaces.ts, which makes it visible globally everywhere so it doesn't have to be redeclared in every file it is used in. However, I declared it as potentially undefined (since it is), so I didn't touch a few files that already declared it as non nullable (like NativeEngine) as there would be a ton of changes and I didn't want this PR to get too overloaded. Never mind, not in the mood to battle the custom umd type declaration generation script today.

@ryantrem ryantrem requested review from bghgary and sebavan November 14, 2025 03:37
@bjsplat
Copy link
Collaborator

bjsplat commented Nov 14, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 14, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 14, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 14, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 14, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 14, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 14, 2025

@ryantrem ryantrem marked this pull request as draft November 14, 2025 21:31
Copy link
Contributor

@bghgary bghgary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline.

@ryantrem ryantrem marked this pull request as ready for review November 15, 2025 00:30
@bjsplat
Copy link
Collaborator

bjsplat commented Nov 15, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 15, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 15, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 15, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 15, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 15, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 15, 2025

@deltakosh deltakosh merged commit b709222 into BabylonJS:master Nov 17, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants