Skip to content

CPP shutdown test scenarios #1326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CedricGuillemet wants to merge 2 commits into from
Closed

CPP shutdown test scenarios #1326

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a63a7e
CPP shutdown test scenarios
CedricGuillemet Nov 21, 2023
4d2ce73
Merge branch 'master' of https://github.com/BabylonJS/BabylonNative i…
CedricGuillemet Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 63 additions & 1 deletion Apps/UnitTests/Shared/Tests.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,72 @@ TEST(JSTest, JavaScriptTests)
EXPECT_EQ(code, 0);
}

TEST(NativeAPI, Shutdown)
{
static constexpr char* testScripts[] = {

// warmup, should not crash. Just here to verify StepCode
R"(
var engine = new BABYLON.NativeEngine();
var scene = new BABYLON.Scene(engine);
StepCode();
)",
// Async operation (crash with v8, not Chakra)
R"(
var engine = new BABYLON.NativeEngine();
var scene = new BABYLON.Scene(engine);
const texture = new BABYLON.Texture("https://assets.babylonjs.com/textures/earth.jpg", scene, false, false, 0, ()=>{
console.log("onLoadObservable", texture.getSize().width);
});
StepCode();
)",
// crash with V8/Chakra : Looks like GC is kicking texture (?) before onLoadObservable is called. => Access violation reading location 0x0000000000000000.
R"(
var engine = new BABYLON.NativeEngine();
var scene = new BABYLON.Scene(engine);
const texture = new BABYLON.Texture("https://assets.babylonjs.com/textures/earth.jpg", scene);
texture.onLoadObservable.addOnce(() => {
console.log("onLoadObservable", texture.getSize().width);
StepCode();
});
)",
};
int scriptIndex{};
for (const auto testScript: testScripts)
{
Babylon::Graphics::Device device = deviceTestConfig;
std::promise<int32_t> stepCode;

Babylon::AppRuntime runtime{};
runtime.Dispatch([&device, &stepCode](Napi::Env env) {
device.AddToJavaScript(env);

Babylon::Polyfills::XMLHttpRequest::Initialize(env);
Babylon::Polyfills::Console::Initialize(env, [](const char* message, auto) {
printf("%s", message);
fflush(stdout);
});

env.Global().Set("StepCode", Napi::Function::New(env, [&stepCode](const Napi::CallbackInfo& ) {
stepCode.set_value(1);
}, "StepCode"));

Babylon::Polyfills::Window::Initialize(env);
Babylon::Plugins::NativeEngine::Initialize(env);
});

Babylon::ScriptLoader loader{runtime};
loader.LoadScript("app:///Scripts/babylon.max.js");
loader.LoadScript("app:///Scripts/babylonjs.materials.js");
loader.Eval(testScript, "testScript");
auto code{stepCode.get_future().get()}; // waiting step before disposing appruntime
printf("End of test %d\n", scriptIndex++);
}
}
/*
This test does a serie of initialization and shutdowns.
It needs the shutdown PR to be merged before running properly.
TEST(NativeAPI, LifeCycle)
TEST(NativeAPI, life_cycle)
{
for (int cycle = 0; cycle < 20; cycle++)
{
Expand Down