Skip to content

Commit 28731c8

Browse files
android build
1 parent 729e207 commit 28731c8

File tree

4 files changed

+16
-12
lines changed

4 files changed

+16
-12
lines changed

Modules/@babylonjs/react-native/android/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,6 @@ if (EXISTS "${TURBOMODULE_DIR}/CMakeLists.txt")
190190
endif()
191191

192192
target_include_directories(BabylonNative PRIVATE ${SHARED_INCLUDES})
193-
194193
else()
195194
# <= React Native 0.70
196195
# Define a minimal version of libturbomodulejsijni.so that includes CallInvokerHolder.cpp.

Modules/@babylonjs/react-native/android/build.gradle

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ if ( propertiesFile.isFile() ) {
3636

3737
def cpp_distribution = (REACT_VERSION >= 71) ? "c++_shared" : "c++_static";
3838

39-
def basekitBuild = 0
39+
def basekitBuild = "ON"
4040
if (project.hasProperty("BASEKIT_BUILD")) {
4141
basekitBuild = project.getProperty("BASEKIT_BUILD")
4242
}
@@ -96,7 +96,9 @@ android {
9696
"-DFETCHCONTENT_SOURCE_DIR_URLLIB=../shared/BabylonNative/deps/urllib-src",
9797
"-DFETCHCONTENT_SOURCE_DIR_SPIRV-CROSS=../shared/BabylonNative/deps/spirv-cross-src",
9898
"-DFETCHCONTENT_SOURCE_DIR_LIBWEBP=../shared/BabylonNative/deps/libwebp-src",
99-
"-DFETCHCONTENT_SOURCE_DIR_GLSLANG=../shared/BabylonNative/deps/glslang-src"
99+
"-DFETCHCONTENT_SOURCE_DIR_GLSLANG=../shared/BabylonNative/deps/glslang-src",
100+
"-DFETCHCONTENT_SOURCE_DIR_BASE-N=../shared/BabylonNative/deps/base-n-src",
101+
"-DFETCHCONTENT_SOURCE_DIR_ANDROIDEXTENSIONS=../shared/BabylonNative/deps/androidextensions-src"
100102
}
101103
}
102104
ndk {

Modules/@babylonjs/react-native/shared/CMakeLists.txt

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,17 @@
11
include(FetchContent)
22

3+
if (${BASEKIT_BUILD})
4+
set(BABYLON_NATIVE_PLUGIN_NATIVEXR OFF CACHE BOOL "")
5+
set(BABYLON_NATIVE_PLUGIN_NATIVECAMERA OFF CACHE BOOL "")
6+
endif()
7+
38
add_subdirectory(${CMAKE_CURRENT_LIST_DIR}/BabylonNative)
49

510
set(SHARED_INCLUDES
6-
"${CMAKE_CURRENT_LIST_DIR}")
11+
"${CMAKE_CURRENT_LIST_DIR}" PARENT_SCOPE)
712

813
set(SHARED_SOURCES
914
"${CMAKE_CURRENT_LIST_DIR}/DispatchFunction.h"
1015
"${CMAKE_CURRENT_LIST_DIR}/BabylonNative.h"
11-
"${CMAKE_CURRENT_LIST_DIR}/BabylonNative.cpp")
16+
"${CMAKE_CURRENT_LIST_DIR}/BabylonNative.cpp" PARENT_SCOPE)
1217

13-
if (${BASEKIT_BUILD})
14-
set(BABYLON_NATIVE_PLUGIN_NATIVEXR OFF CACHE BOOL "")
15-
set(BABYLON_NATIVE_PLUGIN_NATIVECAMERA OFF CACHE BOOL "")
16-
endif()

Package/gulpfile.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -680,8 +680,10 @@ const patchPackageVersion = async () => {
680680
}
681681

682682

683-
const COMMIT_ID = '7f82d72f22e9789b9b66cb837aec0c9bc8ff65ee';
684-
const ZIP_URL = `https://github.com/BabylonJS/BabylonNative/archive/${COMMIT_ID}.zip`;
683+
//const COMMIT_ID = '7f82d72f22e9789b9b66cb837aec0c9bc8ff65ee';
684+
//const ZIP_URL = `https://github.com/BabylonJS/BabylonNative/archive/${COMMIT_ID}.zip`;
685+
const COMMIT_ID = '21911774d516e677e99baecbee6054de9429f4b6';
686+
const ZIP_URL = `https://github.com/CedricGuillemet/BabylonNative/archive/${COMMIT_ID}.zip`;
685687
const TARGET_DIR = path.resolve(__dirname, '../Modules/@babylonjs/react-native/shared/BabylonNative');
686688
const ZIP_PATH = path.join(TARGET_DIR, `${COMMIT_ID}.zip`);
687689
const UNZIP_FOLDER = path.join(TARGET_DIR, `BabylonNative-${COMMIT_ID}`);
@@ -726,7 +728,7 @@ function deleteFile(filePath) {
726728
}
727729

728730
function runCMake(buildDir) {
729-
let cmakeCommand = `cmake -S . -B ../tempBuild`;
731+
let cmakeCommand = `cmake -S . -B ../tempBuild -DBABYLON_NATIVE_BUILD_SOURCETREE=ON`;
730732

731733
exec(cmakeCommand, buildDir);
732734
}

0 commit comments

Comments
 (0)