BABYLON_NATIVE_DISABLE_WEBMIN#707
Merged
CedricGuillemet merged 7 commits intoBabylonJS:masterfrom Mar 18, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the BabylonNative source snapshot used by the React Native package and configures the embedded BabylonNative CMake wrapper to disable WebMini during builds, aligning the package with upcoming BABYLON_NATIVE_DISABLE_WEBMIN behavior.
Changes:
- Bump the BabylonNative pinned commit used by
gulpfile.jspackaging tooling. - Set
BABYLON_NATIVE_DISABLE_WEBMINtoONin the BabylonNative wrapperCMakeLists.txt.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Package/gulpfile.js | Updates the pinned BabylonNative commit hash used when downloading/assembling the BabylonNative source snapshot. |
| Modules/@babylonjs/react-native/shared/BabylonNative/CMakeLists.txt | Forces BABYLON_NATIVE_DISABLE_WEBMIN on when configuring the BabylonNative subproject. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
CedricGuillemet
changed the title
bkaradzic-microsoft
approved these changes
Mar 18, 2026
bghgary
reviewed
Mar 18, 2026
Comment on lines
+86
to
+90
| #if defined(__APPLE__) | ||
| m_graphicsConfig.Window = (Babylon::Graphics::WindowT)window.layer; | ||
| #else | ||
| m_graphicsConfig.Window = window; | ||
| #endif |
Contributor
There was a problem hiding this comment.
This doesn't seem good. Can we update the code to pass in a layer?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.