Skip to content

Conversation

@BhargaviYamanuri
Copy link
Collaborator

  • Created Custom card journey with MVI architecture.
  • It will give understanding of how to crate a journey.
  • We used modular concept.

BhargaviYamanuri and others added 8 commits February 19, 2024 16:34
# Conflicts:
#	app/src/main/assets/backbase/config.json
#	app/src/main/res/navigation/navigation_main.xml
# Conflicts:
#	accounts-journey/src/main/kotlin/com/backbase/accounts_journey/presentation/accountlist/ui/AccountListFragment.kt
#	app/src/main/kotlin/com/backbase/golden_sample_app/MainApplication.kt
#	settings.gradle.kts
# Conflicts:
#	accounts-journey/src/main/kotlin/com/backbase/accounts_journey/presentation/accountlist/ui/AccountListFragment.kt
#	accounts-journey/src/main/res/navigation/account_journey_nav_graph.xml
#	accounts-journey/src/main/res/values/strings.xml
#	app/build.gradle.kts
#	app/src/main/kotlin/com/backbase/golden_sample_app/MainApplication.kt
#	app/src/main/res/navigation/navigation_main.xml
#	gradle/backbase.versions.toml
#	settings.gradle.kts
ran detekt
Ran detekt, applied format
@WingEraser
Copy link
Collaborator

WingEraser commented Nov 19, 2024

I checked and merged 2024.09.LTS into this branch.
I ran detekt: 3 issues left for you to fix.
Android 15 got edge to edge enforcement. The toolbar is now behind the system bar. You might want to fix this.

If this is going to be part of the main branch, we need new gradle modules to separate RnD and CS. Now Core-UI module is on the root and use by CS journey. This might be confusing.

Copy link
Collaborator

@charbelmkh charbelmkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer to CONTRIBUTING.md and CATALOG.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants