Skip to content

Conversation

@tcorral
Copy link
Collaborator

@tcorral tcorral commented Oct 1, 2025

Summary

Fixes failing unit tests across the codebase by updating test configurations and adding missing dependencies.

Changes Made

  • Files modified: 25 test files across multiple libraries
  • Changes:
    • Added missing imports and dependencies in test files
    • Updated TestBed configurations to include required modules (HttpClientTestingModule, RouterTestingModule)
    • Added mock services for ActivityMonitorService, AuthService, LocalesService
    • Fixed component instantiation in tests
    • Updated test setup to use proper Angular testing patterns
    • Removed environment-dependent test logic

Areas Affected

  • Main App: app.component.spec.ts, locale-selector.component.spec.ts
  • ACH Positive Pay Journey: HTTP service and component tests
  • Shared Features: Auth guards, interceptors, user context services
  • Transactions Journey: HTTP services, arrangements, route resolvers
  • Transfer Journey: State management, permissions, form components
  • Custom Payment: Initiator service tests

Impact

  • All previously failing unit tests now pass
  • Improved test reliability and maintainability
  • Better alignment with Angular testing best practices

Testing

  • All unit tests pass
  • No functional changes to application code
  • Test coverage maintained

@tcorral tcorral merged commit 38210c0 into main Nov 4, 2025
11 of 51 checks passed
@tcorral tcorral deleted the fix/wf-2228 branch November 4, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants