Release 1.3.0 #253

GMinucci · 2025-02-17T13:30:28Z

What does this PR do

Release milestone 1.3.0

Issues included:

Including other minor changes

Checklist:

I ran make validation locally with success
I have not introduced new bugs
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented on my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new errors

…ersions from homebrew instead of rely on a manually created binary (#196) * chore: install variants via brew instead of 'make ci' * ref: attempt to run 'variants-switch' action with brew bottle installation * docs: adjust documentation about Github Action * chore: remove steps to manually prepare ci build * ci: specify ruby-version during setup * tests: correct FastlaneParametersFactoryTests.testFileWrite_correctOutput * ci: run 'branch' and 'ci' workflows on macos-12 * ci: temporarily disable codecov reports and simplify 'branch' and 'develop' workflows into 'ci' workflow

* tests: improve unit tests code coverage * fix: swiftlint warnings * fix: update copyright

* feature: Add github issue template. Add git create issue config * fix: update swiftlint rule

* feature: Expose configuration variables key to Variants.swift * fix swiftlint * fix swiftlint * fix swiftlint * fix swiftlint * Update Variats template. Resolve comments

Fixing swiftlint file configuration

* chore: replace old 'VariantsSample' with 'VariantsTestApp' * ref: inject logger into 'XCConfigFactory'; adjust logic to create a 'Variants' PBXGroup and add its files to the 'XcodeProj' * chore: styling changes * chore: adjust Gem dependencies on test app * chore: small styling adjustments based on PR review

[208] Update Gemfile gems

…neration Fix xcconfig randomly sorted generation

…nfigs-simultaneously Supporting variants and pods configs simultaneously

Bumps [activesupport](https://github.com/rails/rails) from 7.0.4 to 7.0.4.2. - [Release notes](https://github.com/rails/rails/releases) - [Changelog](https://github.com/rails/rails/blob/v7.0.4.2/activesupport/CHANGELOG.md) - [Commits](rails/rails@v7.0.4...v7.0.4.2) --- updated-dependencies: - dependency-name: activesupport dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add ability to override app name per variant

* feat: updates checkout method from secrets.yml * chore: fetch remote .rules.toml file for gitleaks

* FIX: Github Marketplace action not picking up the latest release automatically [#189] * FIX: Calling variants setup on M1 mac uses M1 unsupported gems in Gemfile [#208] * FIX: Variants setup on M1 mac does not automatically link variants.xcconfig to xcodeproject [#209] * FIX: Some signing configurations not automatically set in Xcode 14 [#214] * REFACTOR: Signing configuration is updated not only during `setup` but also during `switch` [#215] * REFACTOR: Items in `variants.xcconfig` should be sorted alphabetically [#219] * FEATURE: Ability to add a `postSwitch` command/script, both globally or variant specific [#221] * FEATURE: Add ability to override app name per variant [#216] * FEATURE: Expose configuration keys as static variables in swift [#125] --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: romanhu-bb <[email protected]> Co-authored-by: Aksay Pudukudi Kandhadai (BB) <[email protected]> Co-authored-by: Divine Dube <[email protected]> Co-authored-by: Nour Sandid <[email protected]> Co-authored-by: noursandidb <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Gabriel Minucci <[email protected]> Co-authored-by: Alex Kuziaev <[email protected]>

* ref: change 'Bash().capture' method to select either the stdout or stderr stream * ref: require python3 to run 'gyb' and alert default to fatalError if python3 can't be found * chore: adjust log message to print over multiple lines * ref: better handle GYB error; rely on python2.7 instead of python3; and ensure 'testRender_noSecrets' is corrected * chore: improve error handling * chore: update swiftlint workflow * fix: swiftlint warnings * chore: update Readme * chore: update danger gh action * chore: rename danger build job * chore: update danger gh action * chore: remove Danger api token * chore: temporarily disables danger * fix: re-enable danger --------- Co-authored-by: Gabriel Minucci <[email protected]>

* feat: update mac-os version for github workflow * fix: package conflicts * fix: linter errors * chore: change swift version * chore: replace swift version step with official one * fix: remove make install from CI and run validation instead (lint+tests) * feat: move linter to dedicated workflow * feat: includes fastlane in gem file * fix: naming for ci-validation * fix: install variants before running tests * fix: update make path destination * fix: make path set order * fix: path installation for non linux * fix: set python version on github runner * feat: update gyb to python3 * fix: templates and utils pathing * chore: add temp value to test pipeline * chore: checking path for template in CI * chore: add more debugging for method in CI * chore: add more logging * chore: remove CI logging prints * fix: install bundler before bundle install * fix: disable coverage report due to issues with racc installation * docs: update documentation about Python version from 2.7 to 3

* fix: remove files not needed in Templates folder * chore: update gems * feat: add rbenv and update gems

* fix: remove path config from old installation method * feat: make custom global properties available to all variants * chore: bump nokogiri version * fix: unit tests * fix: linter errors * chore: add unit test for global and variant custom properties

* feat: remove multiple targets for iOS configuration * fix: support file grouping in xcode * fix: linter error * chore: update docs

* feat: include extensions to Matchfile signing * fix: duplicating Variants folder at project * feat: add unit tests * chore: update docs * feat: update signing for targets in xcode * fix: linter and danger errors

* feat: allow selecting signing for release and debug independently * feat: add unit tests * chore: update docs * chore: improve plist parameter value declaration * fix: linter errors

…omatically

…igning-certificate-type Feat: Automatically detect signing certificate

.github/workflows/ci.yml

.github/workflows/danger-swift.yml

.github/workflows/swiftlint.yml

+    runs-on: ubuntu-latest
    steps:
-      - uses: actions/checkout@v1
-      - name: Run SwiftLint
-        run: swiftlint lint --strict --reporter github-actions-logging
+      - uses: actions/checkout@v3
+      - name: GitHub Action for SwiftLint
+        uses: stanfordbdhg/action-swiftlint@v4
+        with:


.github/workflows/swiftlint.yml

* Release 1.2.0 (#232) * FIX: Github Marketplace action not picking up the latest release automatically [#189] * FIX: Calling variants setup on M1 mac uses M1 unsupported gems in Gemfile [#208] * FIX: Variants setup on M1 mac does not automatically link variants.xcconfig to xcodeproject [#209] * FIX: Some signing configurations not automatically set in Xcode 14 [#214] * REFACTOR: Signing configuration is updated not only during `setup` but also during `switch` [#215] * REFACTOR: Items in `variants.xcconfig` should be sorted alphabetically [#219] * FEATURE: Ability to add a `postSwitch` command/script, both globally or variant specific [#221] * FEATURE: Add ability to override app name per variant [#216] * FEATURE: Expose configuration keys as static variables in swift [#125] --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: romanhu-bb <[email protected]> Co-authored-by: Aksay Pudukudi Kandhadai (BB) <[email protected]> Co-authored-by: Divine Dube <[email protected]> Co-authored-by: Nour Sandid <[email protected]> Co-authored-by: noursandidb <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Gabriel Minucci <[email protected]> Co-authored-by: Alex Kuziaev <[email protected]> * Release 1.2.1 (#236) * FIX: Reverting supporting-variants-and-pods-configs-simultaneously, that created a bug which cause the UITests project to import an unneeded pod used by the app project, since the xcconfig is shared between the app and the tests projects (#233) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Nour Sandid <[email protected]> * chore: pin 3rd party actions to commit hash instead of version * chore: add permissions to custom ci jobs * chore: fix linter issues * fix: failing tests --------- Co-authored-by: Arthur Alves <[email protected]>

This reverts commit 9b49b7a.

Revert "Sync main into develop"

Sync main into develop

github-actions · 2025-02-19T13:01:54Z

	Warnings
⚠️	Pull request is relatively big. If this PR contains multiple changes, consider splitting it into separate PRs for easier reviews.

Generated by 🚫 Danger Swift against c2185d4

arthurpalves and others added 30 commits September 30, 2022 15:07

bump: version 1.1.3 (#197)

83e88a7

tests: improve unit tests code coverage (#200)

f3914ad

* tests: improve unit tests code coverage * fix: swiftlint warnings * fix: update copyright

feature: Add github issue template. Add git create issue config (#203)

b0af43d

* feature: Add github issue template. Add git create issue config * fix: update swiftlint rule

feature: Expose configuration variables key to Variants.swift (#201)

560a003

* feature: Expose configuration variables key to Variants.swift * fix swiftlint * fix swiftlint * fix swiftlint * fix swiftlint * Update Variats template. Resolve comments

Fixing swiftlint file configuration

5896ff6

Modified project_params.rb to reflect the right swiftlint configuration

b6b8ec0

Merge pull request #210 from Backbase/fix/swiftlint-template-file

6c465f1

Fixing swiftlint file configuration

Update Gemfile gems

c06fe89

Merge pull request #212 from dubeboy/fix/208-update-gemfile-gems

6e1170d

[208] Update Gemfile gems

Fix alphabetically sort xcconfig file generation

d42944e

swiftlint fixes

23ceb59

fixing swiftlint errors

9f7cc76

swift lint fixes

5238ab9

swiftlint fixes

fb3c573

swiftlint fixes

5789989

file length disabling for XcodeProjFactory

91213ce

Merge pull request #220 from Backbase/fix/xcconfig-randomly-sorted-ge…

029d54b

…neration Fix xcconfig randomly sorted generation

Add support to importing Pods in variants xcconfig

bf76627

fetch Pod config dynamically based on target name

eda234d

fixed comment

67237bf

Merge pull request #222 from Backbase/supporting-variants-and-pods-co…

e9845b4

…nfigs-simultaneously Supporting variants and pods configs simultaneously

Add PostSwitchScript to iOSConfiguration and to iOSVariant

70c6348

fixed USAGE doc

7e96996

lint fix

43ec916

[216] Add ability to override app name per variant (#224)

13ce37b

* Add ability to override app name per variant

[183] Re enable gitleaks (#226)

9432335

* feat: updates checkout method from secrets.yml * chore: fetch remote .rules.toml file for gitleaks

Update PostSwitchScript order & concatenation

3a41fb6

arthurpalves and others added 16 commits October 26, 2023 13:28

fix(security): address Dependabot security findings (#245)

7b40591

* fix: remove files not needed in Templates folder * chore: update gems * feat: add rbenv and update gems

Feat: support file organization using folder reference (#249)

7e39737

* feat: remove multiple targets for iOS configuration * fix: support file grouping in xcode * fix: linter error * chore: update docs

Feat: Handling signing of other targets (extensions) (#250)

559a21f

* feat: include extensions to Matchfile signing * fix: duplicating Variants folder at project * feat: add unit tests * chore: update docs * feat: update signing for targets in xcode * fix: linter and danger errors

Feat: Allow specific signing for debug and release (#251)

5b0f7a4

* feat: allow selecting signing for release and debug independently * feat: add unit tests * chore: update docs * chore: improve plist parameter value declaration * fix: linter errors

implement fetching the signing certificate from the keychain

999bbf8

use the fetchedSigningIdentity when available

20401fd

update fetchSigningCertificate with teamName and certType

bb5ac1a

implement option to enable/disable fetching code signing identity aut…

b6d673e

…omatically

update the documentation

b626e73

clean up unnecessary lines

5701a58

fix tests

8326e0a

Merge pull request #252 from Backbase/feat/239-automatically-detect-s…

9660f62

…igning-certificate-type Feat: Automatically detect signing certificate

GMinucci requested a review from arthurpalves February 17, 2025 13:30

GMinucci self-assigned this Feb 17, 2025

github-advanced-security bot found potential problems Feb 17, 2025

View reviewed changes

GMinucci closed this Feb 19, 2025

GMinucci reopened this Feb 19, 2025

GMinucci added 6 commits February 19, 2025 13:20

Revert "Sync main into develop (#254)"

ec9c8fa

This reverts commit 9b49b7a.

Merge pull request #257 from Backbase/revert-254-chore/sync-develop

a6a65b2

Revert "Sync main into develop"

Merge remote-tracking branch 'origin/main' into chore/sync-main

73f3c22

chore: lock 3rd party actions to commit instead of version

35fee00

fix: linter errors and failing tests

321a750

Merge pull request #258 from Backbase/chore/sync-main

c2185d4

Sync main into develop

GMinucci closed this Feb 19, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Release 1.3.0 #253

Release 1.3.0 #253

Uh oh!

GMinucci commented Feb 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Check warning

Uh oh!

github-actions bot commented Feb 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Release 1.3.0 #253

Release 1.3.0 #253

Uh oh!

Conversation

GMinucci commented Feb 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do

Checklist:

Uh oh!

Uh oh!

Uh oh!

Check warning

Uh oh!

github-actions bot commented Feb 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

GMinucci commented Feb 17, 2025 •

edited

Loading