Skip to content

Disable _TqdmCloser darwin workaround for Python >= 3.14.2 #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
olzhasar-reef wants to merge 1 commit into from
Closed

Disable _TqdmCloser darwin workaround for Python >= 3.14.2 #1127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion b2/_internal/console_tool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -923,7 +923,12 @@ def __enter__(self):
return self

def __exit__(self, exc_type, exc_val, exc_tb):
if sys.platform != 'darwin' or os.environ.get('B2_TEST_DISABLE_TQDM_CLOSER'):
if (
sys.platform != 'darwin'
or sys.version_info < (3, 11)
or sys.version_info > (3, 14, 1)
or os.environ.get('B2_TEST_DISABLE_TQDM_CLOSER')
):
return
try:
from multiprocessing.synchronize import SemLock
Expand Down
1 change: 1 addition & 0 deletions changelog.d/+tqdm-closer-python314.fixed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Disable Tqdm semaphore leak workaround for Python >=3.14.2, as apparently it is no longer an issue in newer versions.
4 changes: 2 additions & 2 deletions test/integration/test_tqdm_closer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@


@pytest.mark.skipif(
(sys.platform != 'darwin') or ((sys.version_info.major, sys.version_info.minor) < (3, 11)),
reason='Tqdm closing error only occurs on OSX and python 3.11 or newer',
(sys.platform != 'darwin') or (sys.version_info < (3, 11)) or (sys.version_info > (3, 14, 1)),
reason='Tqdm closing error only occurs on OSX and python >=3.11 up to 3.14.2',
)
def test_tqdm_closer(b2_tool, bucket, file_name):
# test that stderr doesn't contain any warning, in particular warnings about multiprocessing resource tracker
Expand Down
Loading