Skip to content

bug: add missing setting check for workspace_status_json on route#230

Merged
asullivan-blze merged 1 commit intomainfrom
kphoenix-bug-link-config-setting-into-route
Mar 16, 2026
Merged

bug: add missing setting check for workspace_status_json on route#230
asullivan-blze merged 1 commit intomainfrom
kphoenix-bug-link-config-setting-into-route

Conversation

@asullivan-blze
Copy link
Copy Markdown
Contributor

What and why?

The route for /api/workspaces/status was found to be missing the corresponding check within the route to only display information if the boardwalkd option was set.

How was this tested?

Alternating between the version of serving the app with and without --workspace-status-json:

(boardwalk-py3.12) asullivan@MBP-NT9RPG2XV7 boardwalk % poetry run boardwalkd serve \
                --develop \
                                --host-header-pattern="(localhost|127\.0\.0\.1)" \
                --port=8888 \
                --url='http://localhost:8888'
404 GET /api/workspaces/status (127.0.0.1) 1.61ms
^C
Aborted!
(boardwalk-py3.12) asullivan@MBP-NT9RPG2XV7 boardwalk % make develop-server 
poetry install
Installing dependencies from lock file

No dependencies to install or update

Installing the current project: boardwalk (0.8.28)
poetry run boardwalkd serve \
		--develop \
		--workspace-status-json \
		--host-header-pattern="(localhost|127\.0\.0\.1)" \
		--port=8888 \
		--url='http://localhost:8888'
404 GET /favicon.ico (127.0.0.1) 3.84ms
^C
Aborted!
make: *** [develop-server] Error 1

Checklist

  • Have you updated the version in the [project] section of
    the pyproject.toml file (if applicable)?

Copy link
Copy Markdown

@agouldingbb agouldingbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asullivan-blze asullivan-blze merged commit 40e48bf into main Mar 16, 2026
7 checks passed
@asullivan-blze asullivan-blze deleted the kphoenix-bug-link-config-setting-into-route branch March 16, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants