Cumulative improvements #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… proof generation
Fixed critical bugs in deserializeCiphertext functions where Int32Array views were being created from sliced byte arrays, causing misalignment and data corruption. Instead of using slice().buffer which creates a new ArrayBuffer, now properly pass the buffer reference with correct byte offset. Changes: - src/kem/index.ts: Fixed deserialization of SLSS and TDD ciphertext components to use proper byte offset arithmetic - src/problems/slss/index.ts: Fixed slssDeserializePublicKey to use Int32Array(buffer, offset, length) constructor - src/problems/tdd/index.ts: Fixed tddDeserializePublicKey to use Int32Array(buffer, offset, length) constructor - src/sign/index.ts: Completely rewrote signature functions to match simplified Fiat-Shamir scheme with new MOSAICSignature interface (commitment, challenge, response) This fixes serialization/deserialization round-trip fidelity which is critical for cross-implementation compatibility with the Go implementation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Haiku 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.