Skip to content

BAH-2618 | Email configuration property should be fetched from env and set in OpenMRS email configuration.#119

Open
atish160384 wants to merge 1 commit intomasterfrom
BAH-2618
Open

BAH-2618 | Email configuration property should be fetched from env and set in OpenMRS email configuration.#119
atish160384 wants to merge 1 commit intomasterfrom
BAH-2618

Conversation

@atish160384
Copy link

  • Refractored code in such a way that properties are now first fetched from env file and then thr=e values are set in global properties
  • Use of global properties to fetch smtp.user ,smtp.password and other properties.
  • Intially there was a condition which checks from global property if bahmni.appointment.teleconsultation.sendEmail is true if its true then it checks from env if mail.send property is true removed the double check now only bahmni.appointment.teleconsultation.sendEmail needs to be true.

…moved double check of send.mail =true from env and global prop.
@atish160384 atish160384 requested review from angshu and gsluthra July 10, 2023 13:34
@CLAassistant
Copy link

CLAassistant commented Nov 29, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@angshu
Copy link
Member

angshu commented Oct 27, 2025

I am inclined not to merge this PR.

  1. CLA not signed.
  2. We do not want to add username,password to be fetched or stored onto global property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants