BAH-2618 | Email configuration property should be fetched from env and set in OpenMRS email configuration.#119
Open
atish160384 wants to merge 1 commit intomasterfrom
Open
BAH-2618 | Email configuration property should be fetched from env and set in OpenMRS email configuration.#119atish160384 wants to merge 1 commit intomasterfrom
atish160384 wants to merge 1 commit intomasterfrom
Conversation
atish160384
commented
Jul 10, 2023
- Refractored code in such a way that properties are now first fetched from env file and then thr=e values are set in global properties
- Use of global properties to fetch smtp.user ,smtp.password and other properties.
- Intially there was a condition which checks from global property if bahmni.appointment.teleconsultation.sendEmail is true if its true then it checks from env if mail.send property is true removed the double check now only bahmni.appointment.teleconsultation.sendEmail needs to be true.
…moved double check of send.mail =true from env and global prop.
|
|
Member
|
I am inclined not to merge this PR.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.