Skip to content

fix: output dir is dir#47

Open
SiyaoIsHiding wants to merge 1 commit intoBaileyJM02:mainfrom
SiyaoIsHiding:master
Open

fix: output dir is dir#47
SiyaoIsHiding wants to merge 1 commit intoBaileyJM02:mainfrom
SiyaoIsHiding:master

Conversation

@SiyaoIsHiding
Copy link

In this code snippet:

let OutputDir = getRunnerInput('output_dir', 'built', getRunnerPath);
let OutputDirIsDir = false
try {
    OutputDirIsDir = fs.lstatSync(OutputDir).isDirectory();
} catch { }
if (!OutputDirIsDir) {
    OutputDir += OutputDir.endsWith("/") ? "" : "/"
    CreateOutputDirectory(OutputDir);
}

The current logic is - if the output directory is not a directory, then ensure it ends with a slash.
The logic should be - if the output directory is a directory, then ensure it ends with a slash.

@SiyaoIsHiding
Copy link
Author

@BaileyJM02 , just in case u didn't receive the notification on the pull request :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant