Fix leaderboard roles

This won't actually work for current foil people who need aren't updated. but it will work for any future ones

Author: robotzurg

src/utils/algorithms/calculateMMR.ts

@@ -3,6 +3,7 @@ import {
   getUsersNeedingRoleUpdates,
   updatePlayerMmrAll,
   countPlayerGames,
+  getLeaderboardPosition,
 } from '../queryDB'
 import type { Queues, teamResults } from 'psqlDB'
 import { setUserQueueRole } from 'utils/queueHelpers'
@@ -147,6 +148,8 @@ export async function calculateNewMMR(
       user_id: string
       oldMMR: number
       newMMR: number
+      oldRank: number
+      newRank: number
     }> = []
     const updatePromises: Promise<void>[] = []
     let roleUpdateUsers: string[] = []
@@ -157,17 +160,12 @@ export async function calculateNewMMR(
 
       for (const player of ts.team.players) {
         const oldMMR = player.elo ?? queueSettings.default_elo
+        const oldRank = await getLeaderboardPosition(queueId, player.user_id)
         const oldVolatility = player.volatility ?? 0
 
         const newMMR = parseFloat((oldMMR + mmrChange).toFixed(1))
         const newVolatility = Math.min(oldVolatility + 1, 10)
 
-        playerMMRChanges.push({
-          user_id: player.user_id,
-          oldMMR,
-          newMMR,
-        })
-
         player.elo = clamp(newMMR, 0, 9999)
         player.elo_change = parseFloat(mmrChange.toFixed(1))
         player.volatility = newVolatility
@@ -176,6 +174,16 @@ export async function calculateNewMMR(
           updatePlayerMmrAll(queueId, player.user_id, newMMR, newVolatility),
         )
 
+        const newRank = await getLeaderboardPosition(queueId, player.user_id)
+
+        playerMMRChanges.push({
+          user_id: player.user_id,
+          oldMMR,
+          newMMR,
+          oldRank,
+          newRank,
+        })
+
         const gamesPlayed = await countPlayerGames(queueId, player.user_id)
         if (gamesPlayed === 1) {
           roleUpdateUsers.push(player.user_id)

src/utils/queryDB.ts

@@ -322,7 +322,13 @@ export async function getUserQueueRole(
 
 export async function getUsersNeedingRoleUpdates(
   queueId: number,
-  players: Array<{ user_id: string; oldMMR: number; newMMR: number }>,
+  players: Array<{
+    user_id: string
+    oldMMR: number
+    newMMR: number
+    oldRank: number
+    newRank: number
+  }>,
 ): Promise<string[]> {
   if (players.length === 0) return []
 
@@ -333,6 +339,13 @@ export async function getUsersNeedingRoleUpdates(
     [queueId],
   )
 
+  const leaderboardRoles = await pool.query(
+    `SELECT leaderboard_min, leaderboard_max FROM queue_roles
+     WHERE queue_id = $1 AND mmr_threshold IS NULL
+     ORDER BY leaderboard_min DESC`,
+    [queueId],
+  )
+
   const thresholds = roles.rows.map((r) => r.mmr_threshold)
   const usersToUpdate: string[] = []
 
@@ -343,6 +356,25 @@ export async function getUsersNeedingRoleUpdates(
     if (oldRole !== newRole) {
       usersToUpdate.push(player.user_id)
     }
+
+    // Also handle leaderboard positions
+    if (
+      player.newRank !== null &&
+      leaderboardRoles &&
+      leaderboardRoles.rowCount !== 0
+    ) {
+      const oldLeaderboardRole = leaderboardRoles.rows.find(
+        (r) => r.leaderboard_min <= player.oldRank,
+      )
+      const newLeaderboardRole = leaderboardRoles.rows.find(
+        (r) => r.leaderboard_min <= player.newRank,
+      )
+
+      // Update leaderboard role if its not the same
+      if (oldLeaderboardRole !== newLeaderboardRole) {
+        usersToUpdate.push(player.user_id)
+      }
+    }
   }
 
   return usersToUpdate
@@ -379,13 +411,15 @@ export async function getLeaderboardQueueRole(
     SELECT *
     FROM queue_roles
     WHERE queue_id = $1
-      AND leaderboard_min >= $2
-      AND leaderboard_max <= $2
+      AND leaderboard_min <= $2
+      AND leaderboard_max >= $2
     LIMIT 1
     `,
     [queueId, rank],
   )
 
+  console.log(roleRes.rowCount)
+
   if (roleRes.rowCount === 0) return null
   return roleRes.rows[0]
 }