Detailed logs for LOSS 0.0 MMR #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully this works
ershisan99
reviewed
Oct 16, 2025
src/utils/algorithms/calculateMMR.ts
Outdated
| } | ||
| } | ||
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
Ah yes my favorite kind of change
src/utils/queueHelpers.ts
Outdated
| const eloChanges = await calculatePredictedMMR(queueId, teamData, winningTeamId) | ||
|
|
||
| // Store the calculated ELO changes in match_users table | ||
| for (const [userId, eloChange] of eloChanges.entries()) { |
Collaborator
There was a problem hiding this comment.
This should be a transaction
src/utils/queueHelpers.ts
Outdated
| } | ||
| } | ||
| } catch (err) { | ||
| console.error('Error calculating initial ELO changes:', err) |
Collaborator
There was a problem hiding this comment.
Maybe log additional details for ease of debugging later?
| await updatePlayerWinStreak(player.user_id, queueId, team.score == 1) | ||
|
|
||
| // Update elo change if it exists | ||
| if (player.elo_change !== undefined && player.elo_change !== null) { |
Collaborator
There was a problem hiding this comment.
If Im being honest I don't see why exactly this would've caused issues to begin with. Maybe add some logging first to try and trace back the issue? ,flatMap is usually a bit confusing to work with, I have a suspicion something might be off because of it. Maybe rewrite it to use simpler methods instead?
I also don't see how this change would fix the issue tbh
ershisan99
reviewed
Oct 16, 2025
src/events/interactionCreate.ts
Outdated
| participants: matchUsersArray, | ||
| onComplete: async (interaction, winner) => { | ||
| console.log( | ||
| `Starting finish vote from vote from ${interaction.user.id}`, |
ershisan99
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this works