Reworked Stat command #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robotzurg
reviewed
Nov 1, 2025
Collaborator
robotzurg
left a comment
robotzurg
left a comment
There was a problem hiding this comment.
Looks great! I'll add the rest of the things we discussed
src/utils/canvasHelpers.ts
Outdated
|
|
||
| //draw divides | ||
| ctx.save(); | ||
| const guideRatings = [0, 200, 250, 320, 460, 620, 800, 1000, 1200, 1400, 1600, 1800, 2000, maxRating, minRating] |
Collaborator
There was a problem hiding this comment.
Ideally we take the MMR from the queue roles, and insert them into this list alongside the other hard coded ones. I can do this
src/utils/canvasHelpers.ts
Outdated
| ctx.save(); | ||
| const guideRatings = [0, 200, 250, 320, 460, 620, 800, 1000, 1200, 1400, 1600, 1800, 2000, maxRating, minRating] | ||
| const eloSplits = config.eloSplits | ||
| const eloColors = [config.colors.stone, config.colors.steel, config.colors.gold, config.colors.lucky, config.colors.glass] |
Collaborator
There was a problem hiding this comment.
Colors should maybe be stored in the db rather than hard coded here, but I don't think we're ever going to change the rank colors so it should never matter lol
src/utils/canvasHelpers.ts
Outdated
| ctx.shadowBlur = 0 | ||
| ctx.font = config.fonts.tiny | ||
|
|
||
| if (r == maxRating) { |
Collaborator
There was a problem hiding this comment.
This stuff should pull from the db for mmr thresholds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YOU KNOW WHAT TIME IT IS!!
things you need to do :3
make sure it works on non ranked queues
Change the percentile shit to always say Top
Change the /stats command to have an optional byDate clause that is by default false
Add a way to change the background. I think Jeff said that you can have that in /config?