Fixes for latest dear imgui (tested with 1.92.5) #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- warning C4800: 'int': forcing value to bool 'true' or 'false' (performance warning) - IMGUI_DEFINE_MATH_OPERATORS is not needed by the lib.
…owKeyboardFocus()/PopAllowKeyboardFocus(). Require imgui 1.89.4 (2023-03).
…Index(). Require imgui 1.87 (2022-02).
Owner
|
Hi Omar, yes, I did not have the chance to touch it in a while for various reasons. But I will accept this one just to keep it alive. Many thanks for this. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I realize this project is unmaintained, I am taking the chance that you may trust my input to merge this PR blindly.
If you want to share edit access I would likely merge this myself and anything that would prevent using the library of future version of Dear ImGui.
The first commit should be the same as #161 / #164 / #159 / #158 which I noticed afterwards.