Skip to content

Return static instead of type of class #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ethanransdellverse wants to merge 2 commits into from
Closed

Return static instead of type of class #74

ethanransdellverse wants to merge 2 commits into from

Conversation

@ethanransdellverse
Copy link

@ethanransdellverse ethanransdellverse commented Aug 19, 2024

Linting exposed that these methods should really return static instead of the class type in case they are extended for some reason.

@ethanransdellverse ethanransdellverse requested review from a team as code owners August 19, 2024 18:34
@ethanransdellverse
Copy link
Author

ethanransdellverse commented Aug 23, 2024

@ajrice6713 just wanted to make sure someone saw this 🙏

@ethanransdellverse ethanransdellverse requested review from a team as code owners February 20, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ethanransdellverse