Skip to content

Commit a5f749e

Browse files
authored
SWI-1997 Strip _ from BXML keys that are reserved (#151)
1 parent 5ca26e7 commit a5f749e

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

bandwidth/model/bxml/verb.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ def _set_attributes(self, root: ET.Element):
6060
if self._attributes is not None:
6161
for key, value in self._attributes.items():
6262
if value is not None:
63-
root.set(key, value)
63+
root.set(key.strip("_"), value)
6464

6565
def _to_etree_element(self) -> ET.Element:
6666
"""Generate an ET.Element object from a Verb Object

test-requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
pytest-cov>=2.8.1
2-
pyhamcrest>=2.0.3
2+
pyhamcrest>=2.0.4

test/unit/bxml/test_forward.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,5 +25,5 @@ def setUp(self):
2525
self.test_verb = Verb(tag="test")
2626

2727
def test_to_bxml(self):
28-
expected = '<Forward to="19195554321" _from="19195554322" callTimeout="15" diversionTreatment="propagate" diversionReason="away" uui="93d6f3c0be5845960b744fa28015d8ede84bd1a4;encoding=base64,asdf;encoding=jwt" />'
28+
expected = '<Forward to="19195554321" from="19195554322" callTimeout="15" diversionTreatment="propagate" diversionReason="away" uui="93d6f3c0be5845960b744fa28015d8ede84bd1a4;encoding=base64,asdf;encoding=jwt" />'
2929
assert(expected == self.forward.to_bxml())

0 commit comments

Comments
 (0)