feat: allow routeExit to cancel further routing, pushState#228
Open
barronhagerman wants to merge 1 commit intomasterfrom
Open
feat: allow routeExit to cancel further routing, pushState#228barronhagerman wants to merge 1 commit intomasterfrom
barronhagerman wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds the ability to return
falsein arouteExit()function to stop further routing. A common example of a use case for this feature is to enable checking for unsaved changes and showing a confirmation dialog before exiting the route to allow the user to confirm whether they want to discard their changes or not.shouldPushStateaccessors toContextto allow control of whetherpushState()should be called when settinghandledfromfalsetotrueRouteTreeNode.prototype.activate()so returningfalsein arouteEnter()always prevents any further routing, including any furtherrouteExitorrouteEnter()functions androuteEnterhandlers from being called, but does not necessarily stop the unhandled route handler from firing. Generally, the top-levelrouteEnter()setscontext.handled = true, but that may not always be the case. Setting both of these context properties fixes that.routeExit()handlers to prevent further routing by returningfalselikerouteEnterhandlers. By setting thecontext.shouldPushStatetofalse,context.handledtotrue, and returning, any furtherrouteExitorrouteEnterfunctions are prevented.