Change numeric comparison from double-based to decimal-based #2562
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aligns numeric comparison semantics with recent specification changes (qt4cg/qtspecs#2218). Mixed-type numeric comparisons now convert both operands to decimals (except for
NaN/INFrules), and untyped atomic values are cast to the primitive numeric base type with a fallback toxs:doublewhen required.All numeric
equalandcompareimplementations were updated accordingly, and the casting logic centralized.The following invariant holds for all numeric types:
In principle,
equalcould be removed or implemented in terms ofcompare. However, its direct implementation remains slightly simpler and is therefore retained.Tests have been adapted to the changed semantics.