Added connection support for both omi + omi glasses#4843
Added connection support for both omi + omi glasses#4843MithilSaiReddy wants to merge 4 commits intoBasedHardware:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request successfully refactors the application to support simultaneous connections for an audio device (Omi) and a camera device (OmiGlass), which is a great step towards multimodal conversations. The changes in CaptureProvider correctly separate the logic for audio and photo streaming. However, the core DeviceService has critical issues in the implementation of multi-device support. The _connectToDevice and ensureConnection methods contain incorrect logic, typos, and duplicated code that will cause compilation and runtime errors. I have provided detailed comments and suggestions to address these critical problems.
|
@aaravgarg @mdmohsin7 can u guys check this pr ? |
|
Hey 👋 — thanks for putting this together! Before we can review, could you share a quick live demo (screenshot, screen recording, or terminal output) showing this working on your local or dev environment? In the AI era, writing code is the easy part — what really makes a PR stand out is proof that it works end-to-end. A short video or even a screenshot goes a long way in helping reviewers feel confident about merging. Feel free to update this PR whenever you have something to show. Thanks! 🙏 |
Update CHANGELOG.json for v0.0.1 [skip ci]
@aaravgarg @beastoin check this
Multi-device support (Omi + OmiGlass)
description
Enable simultaneous connection of Omi (audio) and OmiGlass (camera) so both streams feed a single multimodal conversation.
What this delivers
multimodalsource when both devices are active.Key implementation
devices.dart._audioDeviceand_glassDeviceincapture_provider.dart.Impact
Unlocks real multimodal capture using existing WebSocket + conversation structure with minimal architectural change.
Files
lib/services/devices/devices.dartlib/providers/capture_provider.dart