Skip to content

Add missing dispose for CurvedAnimation #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LinXunFeng wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add missing dispose for CurvedAnimation #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/src/image/fade_widget.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ class _FadeWidgetState extends State<FadeWidget>
late Animation<double> opacity;
late AnimationController controller;
late bool hideWidget;
CurvedAnimation? curved;

@override
Widget build(BuildContext context) {
Expand All @@ -59,6 +60,7 @@ class _FadeWidgetState extends State<FadeWidget>
super.initState();
controller = AnimationController(duration: widget.duration, vsync: this);
final curved = CurvedAnimation(parent: controller, curve: widget.curve);
this.curved = curved;
var begin = widget.direction == AnimationDirection.forward ? 0.0 : 1.0;
var end = widget.direction == AnimationDirection.forward ? 1.0 : 0.0;
opacity = Tween<double>(begin: begin, end: end).animate(curved);
Expand All @@ -81,7 +83,10 @@ class _FadeWidgetState extends State<FadeWidget>
opacity.removeStatusListener(animationStatusChange);
controller.duration = widget.duration;
controller.value = 0;
this.curved?.dispose();
this.curved = null;
final curved = CurvedAnimation(parent: controller, curve: widget.curve);
this.curved = curved;
var begin = widget.direction == AnimationDirection.forward ? 0.0 : 1.0;
var end = widget.direction == AnimationDirection.forward ? 1.0 : 0.0;
opacity = Tween<double>(begin: begin, end: end).animate(curved);
Expand All @@ -101,6 +106,8 @@ class _FadeWidgetState extends State<FadeWidget>
void dispose() {
opacity.removeStatusListener(animationStatusChange);
controller.dispose();
curved?.dispose();
curved = null;
super.dispose();
}

Expand Down