Make result_meta_xdr optional in transaction response#111
Open
brianebert wants to merge 1 commit intoBaseflow:developfrom
Open
Make result_meta_xdr optional in transaction response#111brianebert wants to merge 1 commit intoBaseflow:developfrom
brianebert wants to merge 1 commit intoBaseflow:developfrom
Conversation
Changed result_meta_xdr from String to Option<String> to allow for Horizon not sending field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed result_meta_xdr from String to Option to allow for Horizon not sending field.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
accommodate change in what Horizon sends
error on successful transaction response for want of result_meta_xdr field
🆕 What is the new behavior (if this is a feature change)?
reports successful transaction result.
💥 Does this PR introduce a breaking change?
no
🐛 Recommendations for testing
📝 Links to relevant issues/docs
🤔 Checklist before submitting