Skip to content

Add NODE_VERSION_CHECK_PROJECT option for conditional node version display #2353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seefood merged 2 commits into from
Oct 7, 2025
+30 −0
Merged

Add NODE_VERSION_CHECK_PROJECT option for conditional node version display #2353

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c53f82f
Add NODE_VERSION_CHECK_PROJECT option to conditionally display node v…
seefood Oct 7, 2025
0008d77
Apply review feedback: add explicit return 0
seefood Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions themes/base.theme.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,14 @@ function hg_prompt_vars() {
}

function node_command_version_prompt() {
# Set to 'true' to only show node version in directories with package.json
NODE_VERSION_CHECK_PROJECT="${NODE_VERSION_CHECK_PROJECT:-false}"

# If NODE_VERSION_CHECK_PROJECT is enabled, only show version in Node.js projects
if [[ "${NODE_VERSION_CHECK_PROJECT}" == "true" ]] && ! _is_node_project; then
return
Copy link
Contributor

@akinomyoga akinomyoga Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some specify the return code as return 0, while some don't. Is there a background? If not, I recommend always specifying the return code explicitly. Bash had some strange behaviors of the return statement without exit code inside trap handlers.

fi

local node_version
if _command_exists node; then
node_version="$(node --version 2> /dev/null)"
Expand All @@ -421,11 +429,33 @@ function node_native_version_prompt() {
fi
}

function _is_node_project() {
# Check if we're in a Node.js project by looking for package.json
# Search current directory and parent directories up to $HOME
local dir="${PWD}"
while [[ "${dir}" != "${HOME-}" && "${dir}" != "/" ]]; do
if [[ -f "${dir}/package.json" ]]; then
return 0
fi
dir=$(dirname "${dir}")
done
# Also check $HOME itself
[[ -f "${HOME-}/package.json" ]] && return 0
return 1
}

function node_version_prompt() {
NODE_VERSION_STRATEGY="${NODE_VERSION_STRATEGY:-nvm}"
# Set to 'true' to only show node version in directories with package.json
NODE_VERSION_CHECK_PROJECT="${NODE_VERSION_CHECK_PROJECT:-false}"

_log_debug "node: using version strategy '$NODE_VERSION_STRATEGY'"

# If NODE_VERSION_CHECK_PROJECT is enabled, only show version in Node.js projects
if [[ "${NODE_VERSION_CHECK_PROJECT}" == "true" ]] && ! _is_node_project; then
return
fi

if [ "$NODE_VERSION_STRATEGY" == "nvm" ]; then
nvm_version_prompt
elif [ "$NODE_VERSION_STRATEGY" == "node" ]; then
Expand Down
Loading