further improvements

Author: dooly123

Basis/Packages/com.basis.framework/Networking/BasisNetworkManagement.cs

@@ -165,6 +165,15 @@ public static void SimulateNetworkCompute(float UnscaledDeltaTime)
             BasisNetworkPlayers.PublishReceiversSnapshot();
 
             BoneJobSystem = RemoteBoneJobSystem.Schedule(); // will always be a frame behind
+
+            UnscaledDeltaTime = Math.Max(UnscaledDeltaTime, 0f);
+
+            if (BasisNetworkPlayers.ReceiverCount > BasisRemoteNetworkDriver.FixedCapacity)
+            {
+                BasisDebug.LogError($"Exceeded Fixed Capacity! {BasisNetworkPlayers.ReceiverCount} > {BasisRemoteNetworkDriver.FixedCapacity}", BasisDebug.LogTag.Networking);
+                return;
+            }
+
             for (int Index = 0; Index < BasisNetworkPlayers.ReceiverCount; Index++)
             {
                 BasisNetworkPlayers.ReceiversSnapshot[Index].Compute(UnscaledDeltaTime);

Basis/Packages/com.basis.framework/Networking/Recievers/BasisNetworkReceiver.cs

@@ -41,7 +41,6 @@ public class BasisNetworkReceiver : BasisNetworkPlayer
         private float interpolationTime = 0f; // 0..1 over current->next window
 
         public bool HasBufferHolds;
-        public bool PassedSimulate = false;
 
         // ---------------- staging (ring buffer) ----------------
         private const int MaxStage = 64;
@@ -180,16 +179,12 @@ public void Compute(float unscaledDeltaTime)
                 {
                     windowDuration = 1e-3;
                 }
-
-                double step = Math.Max(unscaledDeltaTime, 0.0);
-
-                int depth = _stagedRing.Count;
-                float rate = 1f + CatchupGain * (depth - TargetJitterDepth);
+                float rate = 1f + CatchupGain * (StagedCount - TargetJitterDepth);
                 rate = Mathf.Clamp(rate, MinPlaybackRate, MaxPlaybackRate);
-                interpolationTime += (float)((step / windowDuration) * rate);
-                PassedSimulate = BasisRemoteNetworkDriver.SetFrameTiming(playerId, interpolationTime, unscaledDeltaTime);
+                interpolationTime += (float)(((double)unscaledDeltaTime / windowDuration) * rate);
+                BasisRemoteNetworkDriver.SetFrameTiming(playerId, interpolationTime, unscaledDeltaTime);
 
-                if (PassedSimulate && SentLatest)
+                if (SentLatest)
                 {
 
                     BasisRemoteNetworkDriver.SetFrameInputs(
@@ -201,24 +196,26 @@ public void Compute(float unscaledDeltaTime)
                     );
 
                     BasisRemoteNetworkDriver.SetMuscleWindow(playerId, first.Muscles, last.Muscles);
+                    IsDataReady = true;
                     SentLatest = false;
                 }
             }
         }
-
+        public bool IsDataReady = false;
         /// <summary>
         /// Main-thread application step. Pulls posed outputs from the driver and applies
         /// body position/rotation/muscles to the avatar via PoseHandler.
         /// </summary>
         public void Apply()
         {
-            if (PassedSimulate)
+            if (IsDataReady)
             {
                 // These outputs should be stable when simulate passed.
                 BasisRemoteNetworkDriver.GetOutputs_NoAlloc(playerId, out bool outscale, out var ApplyingRotation, out float3 scaledBody);
-                BasisRemoteNetworkDriver.GetMuscleArray(playerId,ref HumanPose,EyesAndMouth,EyesAndMouthOffset,EyeAndMouthCountInBytes);
+                BasisRemoteNetworkDriver.GetMuscleArray(playerId, ref HumanPose, EyesAndMouth, EyesAndMouthOffset, EyeAndMouthCountInBytes);
                 HumanPose.bodyPosition = scaledBody;
                 HumanPose.bodyRotation = ApplyingRotation;
+
                 if (outscale)
                 {
                     ApplyScale();
@@ -231,9 +228,8 @@ public void Apply()
                         DidLastAvatarTransformChanged = false;
                     }
                 }
-                PassedSimulate = false;
             }
-            if (hasRequiredData)
+            if (IsDataReady && hasRequiredData)
             {
                 PoseHandler.SetHumanPose(ref HumanPose);
                 if (HasOverridenDestination)
@@ -264,8 +260,6 @@ public override void Initialize()
             StagedCount = 0;
             ClearAndRelease();
             interpolationTime = 0f;
-            PassedSimulate = false;
-
             // Clear any packets that arrived before init (rare, but safe)
             while (PayloadQueue.TryDequeue(out var buf))
             {
@@ -349,7 +343,6 @@ public override void DeInitialize()
             }
 
             AudioReceiverModule?.OnDestroy();
-            PassedSimulate = false;
         }
 
         public void ReceiveNetworkAudio(ServerAudioSegmentMessage msg)

Basis/Packages/com.basis.framework/Networking/Recievers/BasisRemoteNetworkDriver.cs

@@ -121,12 +121,6 @@ public static void Shutdown()
     /// </summary>
     public static bool SetFrameTiming(int index, float interpolationTime, float deltaTimeSeconds)
     {
-        if ((uint)index >= FixedCapacity)
-        {
-            BasisDebug.LogError("Exceeded Fixed Capacity!", BasisDebug.LogTag.Networking);
-            return false;
-        }
-
         _interpolationTimes[index] = interpolationTime;
         _deltaTimes[index] = deltaTimeSeconds;