Bump golang.org/x/net from 0.23.0 to 0.38.0#129
Bump golang.org/x/net from 0.23.0 to 0.38.0#129dependabot[bot] wants to merge 2 commits intomainfrom
Conversation
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.23.0 to 0.38.0. - [Commits](golang/net@v0.23.0...v0.38.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-version: 0.38.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
dependabot
bot
added
dependencies
xtagon
left a comment
xtagon
left a comment
There was a problem hiding this comment.
Dependabot bumps Go from 1.21 to 1.23, but we'll need to update the dev container version to match.
Github workflows (release and test) are still on Go 1.20, which doesn't match either.
|
There are a few deprecations going along with Go 1.23. Looking into it. |
|
I addressed the deprecations and lints for Go 1.23 - @BattlesnakeOfficial/core-team it would be good to have a second reviewer before we merge. |
| } | ||
|
|
||
| err := rules.PlaceFoodFixed(rand, tempBoardState) | ||
| err := PlaceFoodFixed(rand, tempBoardState, tempEditor) |
There was a problem hiding this comment.
I made that change to make the lint pass, it said the old way was deprecated
There was a problem hiding this comment.
Will this break the map behavior? I didn't test this map specifically
| "image": "mcr.microsoft.com/devcontainers/go:1.21", | ||
| "postCreateCommand": "go mod download", | ||
| "image": "mcr.microsoft.com/devcontainers/go:1.23", | ||
| "postCreateCommand": "sh -c \"go mod download && git config --global --add safe.directory /workspaces/rules\"", |
There was a problem hiding this comment.
Some Go package expects expects the VCS to be available during build and was throwing an error because I was running in the dev container. This allows git to work in the dev container in the workspace directory.
I think there's a way to handle that with a Go flag to not use VCSbuild if you prefer
| @@ -0,0 +1,4 @@ | |||
| * text=auto eol=lf | |||
There was a problem hiding this comment.
Yep, have to do this a lot when switching between Windows and Linux
2 participants
Bumps golang.org/x/net from 0.23.0 to 0.38.0.
Commits
e1fcd82html: properly handle trailing solidus in unquoted attribute value in foreign...ebed060internal/http3: fix build of tests with GOEXPERIMENT=nosynctest1f1fa29publicsuffix: regenerate table1215081http2: improve error when server sends HTTP/1312450ehtml: ensure <search> tag closes <p> and update tests09731f9http2: improve handling of lost PING in Server55989e2http2/h2c: use ResponseController for hijacking connections2914f46websocket: re-recommend gorilla/websocket99b3ae0go.mod: update golang.org/x dependencies85d1d54go.mod: update golang.org/x dependenciesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.