Adjusting base_score for BaseBoostingAssembler and XGBoostTreeModelAssembler#596
Open
NinaHerrmann wants to merge 1 commit intoBayesWitnesses:masterfrom
Open
Adjusting base_score for BaseBoostingAssembler and XGBoostTreeModelAssembler#596NinaHerrmann wants to merge 1 commit intoBayesWitnesses:masterfrom
NinaHerrmann wants to merge 1 commit intoBayesWitnesses:masterfrom
Conversation
…conditional checks for param base_score and intercept value for XGBoostTreeModelAssembler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all thank you for the library, I really appreciate using it. I am not to familiar with python libraries so excuse me if I am missing something obvious.
Problem:
When generating XGBoost models I came across the error:
XGBoost 2.0 New says:
github
Proposed solution:
To be compatible I check for None in
BaseBoostingAssemblerand check the two different ways (model.get_params().get("base_score")andmodel.intercept_ is not None) inXGBoostTreeModelAssemblerpassing it to the super.Related:
#587 #581
Thanks for your feedback!