Skip to content

fix focus to use default focus to leave the browser's default focus sufficiently contrasted on all interactive elements #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix focus to use default focus to leave the browser's default focus sufficiently contrasted on all interactive elements #466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions src/scss/02-tools/_m-select-custom.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,17 +52,4 @@
&:hover {
border-color: color.adjust($color-grey-500, $lightness: -10%);
}

// Focus style
&:focus {
color: color.adjust($color-text, $lightness: -10%);
border-color: color.adjust($color-grey-500, $lightness: -20%);
outline: none;
box-shadow: 0 0 1px 3px rgba(59, 153, 252, .7);
box-shadow: 0 0 0 3px -moz-mac-focusring;

option {
outline: none;
}
}
}
3 changes: 1 addition & 2 deletions src/scss/04-utilities/_focus.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ html {
textarea,
[tabindex] {
&:focus-visible {
outline: 2px solid currentColor;
outline-offset: .5rem;
outline-offset: .2rem;
}
}
}
12 changes: 0 additions & 12 deletions src/scss/04-utilities/_seo.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,4 @@
%focus-seo-container {
&:has(:focus-visible) {
outline: 2px solid currentColor;
outline-offset: .5rem;
}

*:focus {
outline: none;
}
}

%seo-container {
@extend %focus-seo-container;
position: relative;
z-index: 1;
cursor: pointer;
Expand Down
4 changes: 0 additions & 4 deletions src/scss/05-components/_skip-links.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,6 @@
font-size: 13px;
color: $color-text;
text-decoration: none;

&:focus {
outline-offset: 3px;
}
}

&:focus-within {
Expand Down
5 changes: 0 additions & 5 deletions src/scss/06-blocks/core/_audio.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,5 @@
&::-webkit-media-controls-panel {
background-color: $color-primary;
}

&:focus {
outline: 2px solid $color-primary;
outline-offset: 5px;
}
}
}
Loading