Add settings to get main parent image #138
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When main variation image is empty, not sending main image. With this configuration you can control this behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When main variation image is empty, not sending main image. With this configuration you can control this behavior
To reproduce the “error”, you can use the
shopping_feed_variation_imageshook.When you are using this hook and you have not set a main variation image, it causes the main image to be the 1st image in the gallery and not the main image.
If you have size variations and color variations, it causes the color images to have the correct gallery and the size images to have the wrong gallery (because it is the same gallery as the parent).
As there is no hook to control this behavior or the data of the products, I have chosen to add this pull request.
Logically you can fix this error by adding by hand all the main images to the variations, but this becomes unrealistic when you have many products with many variations.