add new filters #162
Open
add new filters #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Customize directory where the products's feed is written - Customize products's feed filename - Customize shipping method used when creating the shipping rate during order import
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| * @param OrderResource $sf_order the ShoppingFeed order. | ||
| */ | ||
| $shipping_rate = apply_filters( 'shopping_feed_order_shipping_rate', $shipping_rate, $this->sf_order ); | ||
|
|
There was a problem hiding this comment.
Bug: Filter data type mismatch causes downstream errors.
The filter shopping_feed_order_shipping_rate allows external code to return non-array values that bypass the empty() check but cause errors when accessed as array keys later. If the filter returns a non-empty, non-array value (like a string or number), execution continues past line 111 but then fails at lines 124-131 when trying to access array keys like method_rate_id and method_title on a non-array value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Adds filters to customize feed directories/filename and the shipping rate data during order import, plus tests for feed helper functions.
shopping_feed_feed_directory_path,shopping_feed_feed_parts_directory_path, andshopping_feed_feed_filenameinShoppingFeedHelper.shopping_feed_order_shipping_rateinsrc/Orders/Order/Shipping.phpto allow modifying shipping method data when creating rates.tests/wpunit/Feed/HelperFunctionsTest.phpcovering defaults and filter overrides for feed directory, parts directory, and filename.Written by Cursor Bugbot for commit 7d33ed9. This will update automatically on new commits. Configure here.