Skip to content

Skillion slope #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Beakerboy merged 12 commits into from
Jan 13, 2026
Merged

Skillion slope #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e539614
Create diagnose.test.js
Beakerboy Jan 13, 2026
6dcdb7d
Update diagnose.test.js
Beakerboy Jan 13, 2026
176b72a
Update diagnose.test.js
Beakerboy Jan 13, 2026
7e2f622
Update diagnose.test.js
Beakerboy Jan 13, 2026
63b5ee9
Update diagnose.test.js
Beakerboy Jan 13, 2026
93e43e0
Update diagnose.test.js
Beakerboy Jan 13, 2026
ae1e87b
Update diagnose.test.js
Beakerboy Jan 13, 2026
956e510
Update diagnose.test.js
Beakerboy Jan 13, 2026
88e6936
Update buildingpart.js
Beakerboy Jan 13, 2026
6d38823
Update diagnose.test.js
Beakerboy Jan 13, 2026
97207e6
Update diagnose.test.js
Beakerboy Jan 13, 2026
0f419ca
Rename diagnose.test.js to skillion_slope.test.js
Beakerboy Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/buildingpart.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ class BuildingPart {
(calculatedOptions.roof.shape === 'flat' ? 0 : null) ??
(calculatedOptions.roof.shape === 'dome' || calculatedOptions.roof.shape === 'pyramidal' ? BuildingShapeUtils.calculateRadius(this.shape) : null) ??
(calculatedOptions.roof.shape === 'onion' ? BuildingShapeUtils.calculateRadius(this.shape) * 1.5 : null) ??
(calculatedOptions.roof.shape === 'skillion' ? (calculatedOptions.roof.angle ? Math.cos(calculatedOptions.roof.angle / 360 * 2 * Math.PI) * shapeHeight : 22.5) : null);
(calculatedOptions.roof.shape === 'skillion' ? (calculatedOptions.roof.angle ? Math.cos(calculatedOptions.roof.angle / 360 * 2 * Math.PI) * shapeHeight : Math.cos(22.5 / 360 * 2 * Math.PI) * shapeHeight) : null);

calculatedOptions.building.height = this.options.specified.building.height ??
(isNaN(calculatedOptions.building.levels) ? null : (calculatedOptions.building.levels * 3) + calculatedOptions.roof.height) ??
Expand Down
Loading