Skip to content

Add custom IP bind option#425

Merged
WiserTixx merged 3 commits intominorfrom
custom-bind
Mar 29, 2025
Merged

Add custom IP bind option#425
WiserTixx merged 3 commits intominorfrom
custom-bind

Conversation

@WiserTixx
Copy link
Collaborator

@WiserTixx WiserTixx commented Mar 12, 2025

This PR adds an option in the server config to bind to a custom IP.

  • Review config comment and make sure that it is not confused with port forwarding
  • Validate IP addresses

By creating this pull request, I understand that code that is AI generated or otherwise automatically generated may be rejected without further discussion.
I declare that I fully understand all code I pushed into this PR, and wrote all this code myself and own the rights to this code.

@WiserTixx WiserTixx marked this pull request as ready for review March 15, 2025 21:36
@WiserTixx WiserTixx requested a review from 20dka March 15, 2025 21:36
Copy link
Collaborator

@SaltySnail SaltySnail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WiserTixx WiserTixx merged commit 6c3174a into minor Mar 29, 2025
9 checks passed
@WiserTixx WiserTixx deleted the custom-bind branch March 29, 2025 19:39
@pedrotski
Copy link
Contributor

Only just noticed this update.

Can this please be made to work the same way as PROVIDER_PORT_ENV does. As of right now, it's not going to work on Pterodatyl or WISP out of the box without additional configuration.

@WiserTixx
Copy link
Collaborator Author

Can this please be made to work the same way as PROVIDER_PORT_ENV does.

Sure thing, see #432.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Out-of-range port does not generate an error Allow Custom IP to bind to

4 participants