Conversation
WiserTixx
added a commit
to BeamMP/BeamMP-Launcher
that referenced
this pull request
May 5, 2025
Launcher implementation for BeamMP/BeamMP-Server#430. This PR checks if mods are protected, and if a mod is missing the launcher will notify the user about it and give them instructions on how to resolve it. --- By creating this pull request, I understand that code that is AI generated or otherwise automatically generated may be rejected without further discussion. I declare that I fully understand all code I pushed into this PR, and wrote all this code myself and own the rights to this code.
SaltySnail
requested changes
May 10, 2025
Collaborator
SaltySnail
left a comment
SaltySnail
left a comment
There was a problem hiding this comment.
Code looks good, just some suggestions on stuff the user is going to see
Co-authored-by: SaltySnail <51403141+SaltySnail@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mod database
This PR adds a local database of mods, which is used to cache mod hashes and protection status.
Mod hash caching
Mod hashes will now be cached based on last write date. This will speed up server startup because only the mods with changes will have to be hashed.
Mod protection
You can now protect mods! This will allow you to host a server with copyrighted content without actually hosting the copyrighted content. Just run
protectmod <filename with .zip> <true/false>in the console to protect a mod. Users that join a server with protected mods will have to obtain the file themselves and put it in their launcher's resources folder. The launcher will inform the user about this if the file is missing.Mod reloading
You can now reload client mods while the server is running by using
reloadmodsin the console. Keep in mind that this is mainly intended for development, therefore it will not force client to rejoin and neither will is hot-reload mods on the client.By creating this pull request, I understand that code that is AI generated or otherwise automatically generated may be rejected without further discussion.
I declare that I fully understand all code I pushed into this PR, and wrote all this code myself and own the rights to this code.