Conversation
|
Used an html form directly in the docs page: Which opens a new tab going to a url with the following scheme
|
|
@O1LER the previous Pull request being merged has created 3 conflicts. |
|
@O1LER will you be making any further changes? |
|
Are there changes necessary, does the method of calling the api work like i proposed it? If not, then theres no point in merging this |
I have no way of testing that maybe @WiserTixx can help test the Port Checker. |
|
That doesn't work in the current version. However, I've made a version that does support that, along with the self check route (BeamMP/BeamMP-Server#426). But those changes haven't been deployed yet, as that is something I can't do. |
Done 👍 |
WiserTixx
left a comment
There was a problem hiding this comment.
Final changes to support the official implementation.
Co-authored-by: Tixx <83774803+WiserTixx@users.noreply.github.com>
Co-authored-by: Tixx <83774803+WiserTixx@users.noreply.github.com>
Co-authored-by: Tixx <83774803+WiserTixx@users.noreply.github.com>
Co-authored-by: Tixx <83774803+WiserTixx@users.noreply.github.com>
Co-authored-by: Tixx <83774803+WiserTixx@users.noreply.github.com>
Co-authored-by: Tixx <83774803+WiserTixx@users.noreply.github.com>
Co-authored-by: Tixx <83774803+WiserTixx@users.noreply.github.com>
Co-authored-by: Tixx <83774803+WiserTixx@users.noreply.github.com>
Co-authored-by: Tixx <83774803+WiserTixx@users.noreply.github.com>
Co-authored-by: Tixx <83774803+WiserTixx@users.noreply.github.com>
Co-authored-by: Tixx <83774803+WiserTixx@users.noreply.github.com>
|
It says Tixx requested 1 change but I do not see any change request. |
|
Please do not merge this as the check.beammp.com update hasn't been deployed yet. I'll merge this PR when it is. |

Changes all probablyup references to CheckBeamMP as well as adding a form to input IP and port
Requires the check.beammp.com api to accept key=value pairs
Feel free to change to a different method if this is not suitable