Skip to content

Change to CheckBeamMP#223

Merged
WiserTixx merged 13 commits intoBeamMP:mainfrom
O1LER:checkbeammp
Jun 21, 2025
Merged

Change to CheckBeamMP#223
WiserTixx merged 13 commits intoBeamMP:mainfrom
O1LER:checkbeammp

Conversation

@O1LER
Copy link
Collaborator

@O1LER O1LER commented Jun 2, 2025

Changes all probablyup references to CheckBeamMP as well as adding a form to input IP and port

Requires the check.beammp.com api to accept key=value pairs

Feel free to change to a different method if this is not suitable

@O1LER O1LER mentioned this pull request Jun 2, 2025
@O1LER
Copy link
Collaborator Author

O1LER commented Jun 2, 2025

Used an html form directly in the docs page:

<form action="https://check.beammp.com/api/v2/beammp/" method="get" target="_blank">
  <label for="ip">IP adress:</label>
  <input type="text" id="ip" name="ip"><br>
  <label for="port">Port:</label>
  <input type="text" id="port" name="port"><br>
  <input type="submit" value="CheckBeamMP">
</form>

Which opens a new tab going to a url with the following scheme

https://check.beammp.com/api/v2/beammp/?ip=127.0.0.1&port=30814

image

@Protogen187
Copy link
Collaborator

@O1LER the previous Pull request being merged has created 3 conflicts.

@Protogen187
Copy link
Collaborator

@O1LER will you be making any further changes?

@O1LER
Copy link
Collaborator Author

O1LER commented Jun 11, 2025

Are there changes necessary, does the method of calling the api work like i proposed it? If not, then theres no point in merging this

@Protogen187
Copy link
Collaborator

Are there changes necessary, does the method of calling the api work like i proposed it? If not, then theres no point in merging this

I have no way of testing that maybe @WiserTixx can help test the Port Checker.
Regarding the changes I was refering to the conflicts reported by GitHub.

@WiserTixx
Copy link
Collaborator

WiserTixx commented Jun 11, 2025

That doesn't work in the current version. However, I've made a version that does support that, along with the self check route (BeamMP/BeamMP-Server#426). But those changes haven't been deployed yet, as that is something I can't do.

@O1LER
Copy link
Collaborator Author

O1LER commented Jun 11, 2025

Regarding the changes I was refering to the conflicts reported by GitHub.

Done 👍

Copy link
Collaborator

@WiserTixx WiserTixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final changes to support the official implementation.

Protogen187 and others added 10 commits June 12, 2025 08:12
Co-authored-by: Tixx <83774803+WiserTixx@users.noreply.github.com>
Co-authored-by: Tixx <83774803+WiserTixx@users.noreply.github.com>
Co-authored-by: Tixx <83774803+WiserTixx@users.noreply.github.com>
Co-authored-by: Tixx <83774803+WiserTixx@users.noreply.github.com>
Co-authored-by: Tixx <83774803+WiserTixx@users.noreply.github.com>
Co-authored-by: Tixx <83774803+WiserTixx@users.noreply.github.com>
Co-authored-by: Tixx <83774803+WiserTixx@users.noreply.github.com>
Co-authored-by: Tixx <83774803+WiserTixx@users.noreply.github.com>
Co-authored-by: Tixx <83774803+WiserTixx@users.noreply.github.com>
Co-authored-by: Tixx <83774803+WiserTixx@users.noreply.github.com>
@Protogen187 Protogen187 marked this pull request as ready for review June 12, 2025 06:18
Co-authored-by: Tixx <83774803+WiserTixx@users.noreply.github.com>
@Protogen187
Copy link
Collaborator

It says Tixx requested 1 change but I do not see any change request.

@WiserTixx
Copy link
Collaborator

Please do not merge this as the check.beammp.com update hasn't been deployed yet. I'll merge this PR when it is.

@WiserTixx WiserTixx merged commit 261104e into BeamMP:main Jun 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants