Support partial list update (append) in state manager #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

bushig wants to merge 1 commit into BeanieODM:main from bushig:support_list_append_in_state_manager

bushig commented Feb 28, 2025 •

edited

Loading

What's New

Added smarter handling of array operations with state management. Now when you append to arrays, Beanie uses MongoDB's $push operator rather than replacing the entire array.
Also some changes to docs to make cleaner why one would use state manager.
fixture to check what operations was actually sent to Mongo by motor, instead of using get_changes.

More details

Array append() operations now generate MongoDB $push operations with state_management=True
Only happens when state_management_replace_objects=False (which is the default)
Other array operations (changing items, removing them) still work as before, cause they unsafe for sure.
The get_changes() method still shows the full array for compatibility

Also thinking about adding option for unsafe direct array operations like changing elements by index, but still evaluating if its worth it.

bushig force-pushed the support_list_append_in_state_manager branch from 15385bf to 88d6001 Compare

March 3, 2025 09:38


          support partial list update (append) in state manager

126b258

bushig force-pushed the support_list_append_in_state_manager branch from 88d6001 to 126b258 Compare

March 3, 2025 12:03

Author

bushig commented Mar 3, 2025

Fixed tests, but there is still two failing because of docker hub image pull limits and one seems to be flaky test
Can anyone rerun failing tests?

Member

staticxterm commented Mar 3, 2025

Hi @bushig, thanks for the PR.
I'll rerun the tests. Which reminds me that I should push some PR that would hopefully fix those flaky tests.
When I get some free time, I'll take a look at the PR.

Contributor

github-actions bot commented Apr 18, 2025

This PR is stale because it has been open 45 days with no activity.

github-actions bot added the Stale label

Contributor

github-actions bot commented May 2, 2025

This PR was closed because it has been stalled for 14 days with no activity.

github-actions bot closed this

staticxterm reopened this

staticxterm removed the Stale label

staticxterm requested a review from a team

May 14, 2025 18:06

Contributor

github-actions bot commented Jun 29, 2025

This PR is stale because it has been open 45 days with no activity.

github-actions bot added the Stale label

staticxterm removed the Stale label

Contributor

github-actions bot commented Aug 17, 2025

This PR is stale because it has been open 45 days with no activity.

github-actions bot added the Stale label

staticxterm removed the Stale label

Contributor

github-actions bot commented Oct 5, 2025

This PR is stale because it has been open 45 days with no activity.

github-actions bot added the Stale label

Member

staticxterm commented Oct 6, 2025

@BeanieODM/beanie-devs is anyone willing to take a look at this PR? Although e.g. the data loss issue may still occur due to concurrent update from other processes, I believe this feature and the doc updates are worth merging.

github-actions bot removed the Stale label

Contributor

github-actions bot commented Nov 21, 2025

This PR is stale because it has been open 45 days with no activity.

github-actions bot added the Stale label

staticxterm removed the Stale label

Contributor

github-actions bot commented Jan 15, 2026

This PR is stale because it has been open 45 days with no activity.

github-actions bot added the Stale label

staticxterm removed the Stale label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet