Fix FindQuery.count() ignoring pymongo_kwargs #1269
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FindQuery.count() was not forwarding pymongo_kwargs (like hint) to the count_documents call. This caused performance issues when users tried to use hints for indexed queries. Updated FindQuery.count() to merge pymongo_kwargs into the kwargs dict before passing to count_documents, ensuring all pymongo parameters are properly forwarded. Fixes BeanieODM#1258
…tor imports conditional ConfigDict only exists in pydantic v2, and root_validator is only in pydantic v1. Move these imports to conditional blocks based on IS_PYDANTIC_V2 to fix import errors when running tests with pydantic 1.10.18.
for more information, see https://pre-commit.ci
Contributor
can you sync fork with the main (beanie) so that test can be working |
Contributor
git remote add upstream https://github.com/BeanieODM/beanie.git |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
FindQuery.count()not forwardingpymongo_kwargsto thecount_documents()callChanges
FindQuery.count()to mergeself.pymongo_kwargsinto thekwargsdict before passing tocount_documents()hintfor index optimization) are properly forwardedTest plan
MyCollection.find({...}, hint="my_index").count()now correctly uses the indexFixes #1258