Fix update() raising RevisionIdWasChanged for non-revision DuplicateKeyError #1270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eyError When a Document has a unique indexed attribute, violating the uniqueness constraint was incorrectly raising RevisionIdWasChanged instead of the proper DuplicateKeyError. Updated the exception handler to check if the DuplicateKeyError is actually related to revision_id before converting it to RevisionIdWasChanged. If the error is for a different unique constraint, the original DuplicateKeyError is now re-raised. Fixes BeanieODM#1057
…tor imports conditional ConfigDict only exists in pydantic v2, and root_validator is only in pydantic v1. Move these imports to conditional blocks based on IS_PYDANTIC_V2 to fix import errors when running tests with pydantic 1.10.18.
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
DuplicateKeyErroron unique constraints was being converted toRevisionIdWasChangedRevisionIdWasChangedwhen the duplicate key error is actually related to revision_idChanges
Document.save()to check if theDuplicateKeyErrormentions "revision_id" before converting itDuplicateKeyErrorif it's for a different unique constraintTest plan
DuplicateKeyErroris raised (notRevisionIdWasChanged)Fixes #1057