Upgrade to Svelte5 #146
Closed
Upgrade to Svelte5 #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@BearToCode what are your thoughts on doing this upgrade? The main reason I tested out upgrading was because you can't pass svelte5 components as icons when creating a plugin. |
Closed
Closed
Owner
|
Hi, have you enabled "Allow edits from maintainers"? I can't seem to be able to work on this PR |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran
npx sv migrate svelte-5on each of the packages, fixed some small issues and synchronized dependency versions using the pnpm workspace catalog.