Increase Shiki from 1.4.0 to 3.4.0 #160
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shiki v2 introduces no breaking changes
https://shiki.matsu.io/blog/v2
Shiki v3 renamed
getHighlightertocreateHighlighterand I don't think any of the other removed deprecated APIs are used by Cartahttps://shiki.matsu.io/blog/v3
In
carta-mdonly that one function change was necessary.I was having a module issue with
plugin-code:I updated the
moduleResolutionfromnodetoBundlerThe
nodemodule resolution strategy (now callednode10) is super old. Usingnode16ornodenextis better/stricter, butbundleris the safe choice if you don't want to think about it.One nice thing in the new Shiki is that is adds fontStyle strike through support. This part of the theme is currently broken
https://github.com/BearToCode/carta/blob/master/packages/carta-md/src/lib/internal/assets/theme-light.ts#L230
but on Shiki 3.4.0 it works!