Clarify API client pattern for external third-party APIs#181
Closed
Copilot wants to merge 1 commit intoadd-discogs-supportfrom
Closed
Clarify API client pattern for external third-party APIs#181Copilot wants to merge 1 commit intoadd-discogs-supportfrom
Copilot wants to merge 1 commit intoadd-discogs-supportfrom
Conversation
Copilot
AI
changed the title
[WIP] Update Discogs and Wikipedia/Wikidata support based on PR feedback
Clarify API client pattern for external third-party APIs
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed feedback on PR #180 regarding the use of
kyvsinstance()insrc/helpers/musicbrainz.ts.Analysis
The
instance()function from@/apiis designed exclusively for Spotify API calls:MusicBrainz (and other external APIs like Discogs, Wikidata) require:
Current Implementation Pattern
External APIs consistently use
ky.create()with custom configuration:Using
instance()would send Spotify auth tokens to third-party APIs, creating both functional and security issues.Requested Clarification
Awaiting guidance on whether a different abstraction pattern is desired for external API clients while maintaining proper authentication isolation.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.