Skip to content

2.8.5#22

Merged
jwaisner merged 3 commits intomainfrom
2.8.5
Feb 9, 2025
Merged

2.8.5#22
jwaisner merged 3 commits intomainfrom
2.8.5

Conversation

@N6REJ
Copy link
Collaborator

@N6REJ N6REJ commented Jan 30, 2025

PR Type

Enhancement, Configuration changes


Description

  • Added new configuration files for Composer version 2.8.5.

  • Updated release details in build.properties and releases.properties.

  • Introduced a new composer.json file with caching and PHPUnit requirements.

  • Added a batch script for Composer execution.


Changes walkthrough 📝

Relevant files
Configuration changes
composer.bat
Add batch script for Composer execution                                   

bin/composer2.8.5/composer.bat

  • Added a batch script for Composer execution.
  • Configures COMPOSER_HOME and invokes composer.phar.
  • +3/-0     
    bearsampp.conf
    Add configuration file for Composer 2.8.5                               

    bin/composer2.8.5/bearsampp.conf

  • Added configuration file for Composer version 2.8.5.
  • Includes version, executable, and release placeholders.
  • +4/-0     
    composer.json
    Add `composer.json` with caching and dependencies               

    bin/composer2.8.5/composer.json

  • Added composer.json with caching configuration.
  • Includes PHPUnit as a development dependency.
  • +8/-0     
    build.properties
    Update release date in `build.properties`                               

    build.properties

    • Updated bundle.release to reflect the new release date.
    +1/-1     
    releases.properties
    Add release details for Composer 2.8.5                                     

    releases.properties

    • Added release details for Composer version 2.8.5.
    +1/-0     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @qodo-code-review
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Version Mismatch

    The configured composer version (2.8.3) does not match the actual version being deployed (2.8.5)

    composerVersion = "2.8.3"
    Path Configuration

    The cache directory path uses a Linux-style path placeholder but should be validated to work correctly across different environments

    "cache-dir": "~BEARSAMPP_LIN_PATH~/tmp/composer"

    @qodo-code-review
    Copy link

    qodo-code-review bot commented Jan 30, 2025

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Possible issue
    ✅ Fix version mismatch in config

    The configured composer version (2.8.3) does not match the actual version being
    deployed (2.8.5). Update the version number to match the deployed version.

    bin/composer2.8.5/bearsampp.conf [1]

    -composerVersion = "2.8.3"
    +composerVersion = "2.8.5"

    [Suggestion has been applied]

    Suggestion importance[1-10]: 9

    Why: The version mismatch between config (2.8.3) and actual deployment (2.8.5) could cause serious issues with dependency management and version checking. This inconsistency needs to be fixed to ensure proper functionality.

    9

    @@ -0,0 +1,4 @@
    composerVersion = "2.8.3"

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggestion: Fix version mismatch in config [Possible issue, importance: 9]

    Suggested change
    composerVersion = "2.8.3"
    composerVersion = "2.8.5"

    @jwaisner jwaisner merged commit 058348c into main Feb 9, 2025
    @jwaisner jwaisner deleted the 2.8.5 branch February 9, 2025 17:12
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants