Skip to content

Composer 2.8.6#23

Merged
N6REJ merged 2 commits intomainfrom
2.8.6
Mar 5, 2025
Merged

Composer 2.8.6#23
N6REJ merged 2 commits intomainfrom
2.8.6

Conversation

@jwaisner
Copy link
Contributor

@jwaisner jwaisner commented Mar 3, 2025

PR Type

Enhancement, Configuration changes


Description

  • Added configuration and files for Composer version 2.8.6.

  • Updated build.properties with new release date.

  • Added release URL for Composer 2.8.6 in releases.properties.

  • Introduced new configuration files for Composer execution.


Changes walkthrough 📝

Relevant files
Configuration changes
composer.bat
Added batch script for Composer execution                               

bin/composer2.8.6/composer.bat

  • Added a batch script for Composer execution.
  • Configured COMPOSER_HOME and PHP execution.
  • +3/-0     
    bearsampp.conf
    Added configuration file for Composer 2.8.6                           

    bin/composer2.8.6/bearsampp.conf

  • Added configuration file for Composer 2.8.6.
  • Defined composerVersion and composerExe.
  • Included placeholder for bundleRelease.
  • +4/-0     
    composer.json
    Added Composer JSON configuration file                                     

    bin/composer2.8.6/composer.json

  • Added Composer JSON configuration file.
  • Configured cache directory for Composer.
  • Added phpunit/phpunit as a development dependency.
  • +8/-0     
    build.properties
    Updated release date in build properties                                 

    build.properties

    • Updated bundle.release to new release date.
    +1/-1     
    releases.properties
    Added release URL for Composer 2.8.6                                         

    releases.properties

    • Added release URL for Composer version 2.8.6.
    +1/-0     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @jwaisner jwaisner requested a review from N6REJ as a code owner March 3, 2025 02:05
    @jwaisner jwaisner added the enhancement ✨ Improve program label Mar 3, 2025
    @qodo-code-review
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Path Configuration

    The cache directory path uses a placeholder 'BEARSAMPP_LIN_PATH' which should be validated to ensure it resolves correctly at runtime

    "cache-dir": "~BEARSAMPP_LIN_PATH~/tmp/composer"

    @qodo-code-review
    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    Possible issue
    Add PHP availability check

    Add error handling to verify if PHP is available in the system path before
    execution to prevent silent failures

    bin/composer2.8.6/composer.bat [1-3]

     @echo off
     set COMPOSER_HOME=%~dp0
    +where php >nul 2>nul
    +if %errorlevel% neq 0 (
    +    echo Error: PHP is not available in the system path
    +    exit /b 1
    +)
     @php "%~dp0composer.phar" %*
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    __

    Why: Adding PHP availability check is crucial for preventing silent failures and providing clear error messages when PHP is not available, which would make troubleshooting much easier.

    Medium
    General
    Fix cache directory path resolution

    Use an absolute path or environment variable for cache-dir to prevent potential
    path resolution issues

    bin/composer2.8.6/composer.json [3]

    -"cache-dir": "~BEARSAMPP_LIN_PATH~/tmp/composer"
    +"cache-dir": "%BEARSAMPP_PATH%/tmp/composer"
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    __

    Why: Using Windows environment variable syntax instead of Linux-style path is important for proper cache directory resolution on Windows systems, preventing potential path-related issues.

    Medium
    • More

    @N6REJ N6REJ merged commit 9936603 into main Mar 5, 2025
    @N6REJ N6REJ deleted the 2.8.6 branch March 5, 2025 22:45
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    enhancement ✨ Improve program

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants