Skip to content

Composer 2.8.8#24

Merged
N6REJ merged 1 commit intomainfrom
2.8.8
Apr 22, 2025
Merged

Composer 2.8.8#24
N6REJ merged 1 commit intomainfrom
2.8.8

Conversation

@jwaisner
Copy link
Contributor

@jwaisner jwaisner commented Apr 18, 2025

PR Type

Enhancement


Description

  • Added support for Composer version 2.8.8.

  • Introduced configuration files for Composer 2.8.8.

  • Updated releases.properties with the 2.8.8 release URL.

  • Adjusted build.properties to reflect the new release version.


Changes walkthrough 📝

Relevant files
Enhancement
composer.bat
Add batch script for Composer 2.8.8                                           

bin/composer2.8.8/composer.bat

  • Added a batch script to execute Composer.
  • Set COMPOSER_HOME and invoked composer.phar.
  • +3/-0     
    bearsampp.conf
    Add configuration file for Composer 2.8.8                               

    bin/composer2.8.8/bearsampp.conf

  • Added configuration file for Composer 2.8.8.
  • Defined composerVersion, composerExe, and bundleRelease.
  • +4/-0     
    composer.json
    Add composer.json for Composer 2.8.8                                         

    bin/composer2.8.8/composer.json

  • Added composer.json for Composer 2.8.8.
  • Configured cache directory and development dependencies.
  • +8/-0     
    releases.properties
    Add release URL for Composer 2.8.8                                             

    releases.properties

    • Added release URL for Composer 2.8.8.
    +1/-0     
    Configuration changes
    build.properties
    Update build release version                                                         

    build.properties

    • Updated bundle.release to 2025.4.18.
    +1/-1     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @qodo-code-review
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    @qodo-code-review
    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    Possible issue
    Fix cache directory path

    The cache directory path uses Linux-style path notation (BEARSAMPP_LIN_PATH)
    but this appears to be a Windows environment based on the batch file. This will
    cause cache directory resolution issues.

    bin/composer2.8.8/composer.json [1-8]

     {
       "config": {
    -    "cache-dir": "~BEARSAMPP_LIN_PATH~/tmp/composer"
    +    "cache-dir": "%BEARSAMPP_PATH%\\tmp\\composer"
       },
       "require-dev": {
         "phpunit/phpunit": "^9.0"
       }
     }
    • Apply this suggestion
    Suggestion importance[1-10]: 9

    __

    Why: The current cache path uses Linux-style notation which will fail on Windows. Changing to Windows environment variable format with proper escaping ensures the cache directory will be correctly resolved in the Windows environment.

    High
    Fix environment variable path

    The COMPOSER_HOME environment variable should point to a directory where
    Composer can store configuration and cache, not to the executable's directory.
    This could cause permission issues and unexpected behavior.

    bin/composer2.8.8/composer.bat [1-3]

     @echo off
    -set COMPOSER_HOME=%~dp0
    +set COMPOSER_HOME=%APPDATA%\Composer
     @php "%~dp0composer.phar" %*
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    __

    Why: Setting COMPOSER_HOME to the executable directory is problematic as it could cause permission issues and unexpected behavior. Using %APPDATA%\Composer is the standard location for Composer's home directory on Windows systems.

    Medium
    • More

    @N6REJ N6REJ merged commit 3f50e1a into main Apr 22, 2025
    @N6REJ N6REJ deleted the 2.8.8 branch April 22, 2025 12:57
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants